From nobody Thu Oct 16 23:58:34 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cnlKJ6TxJz6DMqb for ; Thu, 16 Oct 2025 23:58:44 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cnlKJ1f9Gz42KV for ; Thu, 16 Oct 2025 23:58:44 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=kQKbX7Fh; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::f2d as permitted sender) smtp.mailfrom=markjdb@gmail.com Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-87c13813464so23833516d6.1 for ; Thu, 16 Oct 2025 16:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760659118; x=1761263918; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=AtFUnrIphlSL3+NBEE01nPgMsf47kqWuBeDI6YL4JlI=; b=kQKbX7FhcwWgr94xsm44JOK03/Cad317cil5dbqpMXfOSmRsmVFBcjyCS6U+II1sHt qIPh4pSbbOYHIKNQu6xyg/eXQcodgMjy5DAZ31Wwv1YEM11ZcYeoLVK3qrxHxkxv4bsW cCZLAEpIc7TATeO0Gm9j9z7HHk0LsaWrcxhrqgDRKSrroBK7Oy3s78VQvQ0uxQzrsYvo OS8PjJNPqJaFOMqznl5GV6V+uldoFNvjmNvmYA45V2UH7h2oHr8fDJJi3rvqdj0A9G9h 5cQJBWo7Ck88OWEaEcGRlG3ussnUWw9Fz30aPc0xOpfd8L+w5tq9yBwihUUHixxdGxVA BOaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760659118; x=1761263918; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AtFUnrIphlSL3+NBEE01nPgMsf47kqWuBeDI6YL4JlI=; b=eAUcN0vBgQ6+Qwvz2N1UgfujpeKxyj0M4t0Exzh72x8G7fzwK38yAvi5cJAXkosuFk a+30ZU4mU7IorltVJA5KGSG2h2Q7Jf+Y2V3rsYJB4vomtlWP5ylBARtKU7/hEK5Fpg0u UafWDIRjieLY9dP2I3zG09iWfZmZiM9gz6AfVkQZ/8NACuf/8E62Yw0HuLWoRJs17bfK n9yiQmU5x0fI2G4oOYSRGWfouywJQmX3iUb973JdfcIZARtZg0ILsqAIVAbOpJeGP0ey 8GG4qGK2t1Sojftk1aLkm+hVSP/BTUymE09156+773lxnt9PXuNK3mxsMrvWynlkfqsN D+5Q== X-Forwarded-Encrypted: i=1; AJvYcCXSy/lxd9/BVHM3UiXlFLw7LXAxsHsidPAcd7HLoeCMLHuQ0iWoZ49sDcJP8pkZQvr/XZe4qOllrqEmLqvYQmeOEdaZ@freebsd.org X-Gm-Message-State: AOJu0YzI8z2vXsiImEWT1LDGNoZWi1lzGWnfpzQp30EIr+tILzBFoH3w a+TiXV2mfzCR7xZfsuoLmfIQc+nW5iMepn9xkmaxM0X9noo3A/fZkGg0WS+ZHz9OCp8= X-Gm-Gg: ASbGncu7XDrB2AAEwIwQBtcKtwMnf7qibt0bkCQrdebXyiv5NOW+c9JsHGmiE/Hk0sq Ux4C0L/hX42FSE62nZl41foDufFZoh1JQIakVDXsjM2UTcMXuUZse7IEvbCeV3/w0LYinDBeJOs byDwU1xfQ0jpEahNT+/pZBQ4wNpiPAuHZBuDu9m89CEpVZnNMWPPOz0FpdTJkcFkX7398NJXYjA vufkZtIL+kugFsUf4rpF77KKzIXOYItgRhu2eUdJ916/N2/tirSw7JWJ0lDRJkyEyL46Ai9mQz5 hSHqKXoR7DTyP09BXPTe1Mq7TD5/f4H3uLofzqX6pY6+YsrHnK28/ynpEFMWpJ+ZlbBIahNykPj utngNXcclUgFgxaYlfUNYaHg+h9hb5YnGTmRwkLZjyP2P8qYJgCVPYmpjWQ/vxwn0/UfDcwZxHw 3GTLQfEJITUimB2A== X-Google-Smtp-Source: AGHT+IENY/+yB6O4YlD/m62H6Hfc1agBNCS8ZbT94wa7JH9GaWGlU1xV/mrppFuPJRDaPQFLbnooTw== X-Received: by 2002:a05:622a:1113:b0:4e8:91a4:241a with SMTP id d75a77b69052e-4e89d2c9aeamr24049421cf.37.1760659118413; Thu, 16 Oct 2025 16:58:38 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4e881b10bbesm54210561cf.0.2025.10.16.16.58.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Oct 2025 16:58:37 -0700 (PDT) Date: Thu, 16 Oct 2025 19:58:34 -0400 From: Mark Johnston To: Rick Macklem Cc: "David E. O'Brien" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0050289464fa - main - style(9): white space after ; and around binary operators Message-ID: References: <202510162205.59GM5ZvD042942@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_TO(0.00)[gmail.com]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f2d:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TAGGED_RCPT(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4cnlKJ1f9Gz42KV On Thu, Oct 16, 2025 at 04:21:45PM -0700, Rick Macklem wrote: > Please be aware of the following snippets from "man 9 style": > > In general code can be considered "new code" when it makes up about 50% > or more of the file(s) involved. This is enough to break precedents in > the existing code and use the current style guidelines. > > Stylistic changes (including whitespace changes) are hard on the source > repository and are to be avoided without good reason. +1 This kind of change accomplishes nothing except to be a source of merge conflicts for others to deal with. > rick > > On Thu, Oct 16, 2025 at 3:05 PM David E. O'Brien wrote: > > > > CAUTION: This email originated from outside of the University of Guelph. Do not click links or open attachments unless you recognize the sender and know the content is safe. If in doubt, forward suspicious emails to IThelp@uoguelph.ca. > > > > The branch main has been updated by obrien: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=0050289464fa56ec79e060b8d8378b9ff7145a0e > > > > commit 0050289464fa56ec79e060b8d8378b9ff7145a0e > > Author: David E. O'Brien > > AuthorDate: 2025-10-15 05:22:00 +0000 > > Commit: David E. O'Brien > > CommitDate: 2025-10-16 22:02:50 +0000 > > > > style(9): white space after ; and around binary operators > > > > in for() loops. Also, use 'while', where only the > > conditional test of 'for' was used. > > > > Reviewed by: sjg