From owner-cvs-all@FreeBSD.ORG Fri Oct 31 08:28:39 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B390716A4CE; Fri, 31 Oct 2003 08:28:39 -0800 (PST) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5DB543F3F; Fri, 31 Oct 2003 08:28:38 -0800 (PST) (envelope-from sam@errno.com) Received: from 66.127.85.91 ([66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.9) with ESMTP id h9VGSa0x052227 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Fri, 31 Oct 2003 08:28:38 -0800 (PST) (envelope-from sam@errno.com) From: Sam Leffler Organization: Errno Consulting To: Hajimu UMEMOTO , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Date: Fri, 31 Oct 2003 08:30:19 -0800 User-Agent: KMail/1.5.3 References: <200310311621.h9VGLQcF082946@repoman.freebsd.org> In-Reply-To: <200310311621.h9VGLQcF082946@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200310310830.19903.sam@errno.com> Subject: Re: cvs commit: src/sys/netinet6 icmp6.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Oct 2003 16:28:39 -0000 On Friday 31 October 2003 08:21 am, Hajimu UMEMOTO wrote: > ume 2003/10/31 08:21:26 PST > > FreeBSD src repository > > Modified files: > sys/netinet6 icmp6.c > Log: > (icmp6_rip6_input) if the received data is small enough but in an > mbuf cluster, copy the data to a separate mbuf that do not use a > cluster. this change will reduce the possiblity of packet loss > in the socket layer. This may be the first of several similar commits to do this throughout IPv6, but I think optimizations like this really belong in the network drivers; or at least at that level. OTOH I'm not sure doing this is worthwhile at all. I'd be interested in real experiences to back this up. FWIW I noticed that some Linux network drivers do this. Sam