From owner-freebsd-stable@FreeBSD.ORG Mon Jun 24 22:19:48 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 015A56D8 for ; Mon, 24 Jun 2013 22:19:47 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) by mx1.freebsd.org (Postfix) with ESMTP id B1A5E1271 for ; Mon, 24 Jun 2013 22:19:46 +0000 (UTC) Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id D8A0C28427; Tue, 25 Jun 2013 00:19:45 +0200 (CEST) Received: from [192.168.1.2] (ip-89-177-49-222.net.upcbroadband.cz [89.177.49.222]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 97AEF28422; Tue, 25 Jun 2013 00:19:44 +0200 (CEST) Message-ID: <51C8C5FF.6050603@quip.cz> Date: Tue, 25 Jun 2013 00:19:43 +0200 From: Miroslav Lachman <000.fbsd@quip.cz> User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1.19) Gecko/20110420 Lightning/1.0b1 SeaMonkey/2.0.14 MIME-Version: 1.0 To: Scot Hetzel Subject: Re: sshd didn't run after upgrade to FreeBSD 8.4 References: <51C22E11.3020008@quip.cz> <51C23ED9.7070107@quip.cz> <51C2499B.2060209@quip.cz> <51C2CB42.4030301@dilkie.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Kimmo Paasiala , Steven Hartland , freebsd-stable Stable X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jun 2013 22:19:48 -0000 Scot Hetzel wrote: > On Thu, Jun 20, 2013 at 4:28 AM, Lee Dilkie wrote: >> >> On 6/19/2013 8:24 PM, Kimmo Paasiala wrote: >>> Ok, this is crazy. If you put one space after the VersionAddendum >>> keyword you get exactly what you want, an empty VersionAddendum >>> string. If there's no space but a newline right after the >>> VersionAddendum keyword, sshd(8) complains about the line and refuses >>> to start. So this is ok (without the single quotes, they are just to >>> show the endings of the lines): >>> >>> 'VersionAddendum' >>> >>> But this is not: >>> >>> 'VersionAddendum' >>> >>> What are the OpenSSH devs thinking? >>> >>> -Kimmo >> >> I'd call it a bug. >> > > crypto/openssh/servconf.c > > 1553 case sVersionAddendum: > 1554 if (cp == NULL) > 1555 fatal("%.200s line %d: Missing > argument.", filename, > 1556 linenum); > 1557 len = strspn(cp, WHITESPACE); > 1558 if (*activep&& options->version_addendum == NULL) { > 1559 if (strcasecmp(cp + len, "none") == 0) > 1560 options->version_addendum = xstrdup(""); > 1561 else if (strchr(cp + len, '\r') != NULL) > 1562 fatal("%.200s line %d: Invalid argument", > 1563 filename, linenum); > 1564 else > 1565 options->version_addendum = > xstrdup(cp + len); > 1566 } > 1567 return 0; > > Looks like if you specify: > > VersionAddendum none > > it won't display the additional info. Thank you for your suggestion, "none" really works. I will use it as a workaround. I think the issue needs to be mentioned in Release Notes and/or UPDATING anyway. Miroslav Lachman