Date: Wed, 19 May 2010 13:07:35 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: bug-followup@freebsd.org Cc: Sunpoet Po-Chuan Hsieh <sunpoet@sunpoet.net>, freebsd-java@freebsd.org Subject: Re: ports/146724: [PATCH] java/openjdk6: fix pkg-message Message-ID: <201005191307.37338.jkim@FreeBSD.org> In-Reply-To: <20100519083417.BD2662AEC6AD@sunpoet.net> References: <20100519083417.BD2662AEC6AD@sunpoet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 19 May 2010 04:34 am, Sunpoet Po-Chuan Hsieh wrote: > >Submitter-Id: current-users > >Originator: Sunpoet Po-Chuan Hsieh > >Organization: SUNPOET.net > >Confidential: no > >Synopsis: [PATCH] java/openjdk6: fix pkg-message > >Severity: non-critical > >Priority: low > >Category: ports > >Class: change-request > >Release: FreeBSD 8.1-PRERELEASE amd64 > >Environment: > > System: FreeBSD bonjour.sunpoet.net 8.1-PRERELEASE FreeBSD > 8.1-PRERELEASE #0: Wed May 19 00:13:00 CST 2010 > > >Description: > > Fix pkg-message according to fdescfs(5). > > Port maintainer (java@FreeBSD.org) is cc'd. > > Generated with FreeBSD Port Tools 0.99 > > >How-To-Repeat: > >Fix: > > --- openjdk6-b19_1.patch begins here --- > diff -ruN --exclude=CVS /usr/ports/java/openjdk6/pkg-message > /usr/ports/sunpoet/openjdk6/pkg-message --- > /usr/ports/java/openjdk6/pkg-message 2010-05-18 07:19:45.000000000 > +0800 +++ /usr/ports/sunpoet/openjdk6/pkg-message 2010-05-19 > 08:58:40.000000000 +0800 @@ -4,10 +4,10 @@ > > If you have not done it yet, please do the following: > > - mount -t fdescfs fdesc /dev/fd > + mount -t fdescfs null /dev/fd > > To make it permanent, you need the following line in /etc/fstab: > > - fdesc /dev/fd fdescfs rw 0 0 > + null /dev/fd fdescfs rw 0 0 > > > =================================================================== >=== --- openjdk6-b19_1.patch ends here --- In EXAMPLES section, probably fdescfs(5) is the only one that says "null" for the pseudo device, e.g., devfs(5): mount -t devfs devfs /dev linprocfs(5): mount -t linprocfs linproc /compat/linux/proc linsysfs(5): mount -t linsysfs linsys /compat/linux/sys procfs(5): mount -t procfs proc /proc In fact, it may be more confusing for nullfs users. In SYSNOPSIS section, actually fdescfs(5) says: fdescfs /dev/fd fdescfs rw 0 0 Many manual pages for pseudo file systems have similar SYNOPSIS, e.g., devfs(5): devfs /dev devfs rw 0 0 linprocfs(5): linproc /compat/linux/proc linprocfs rw 0 0 linsysfs(5)L linsys /compat/linux/sys linsysfs rw 0 0 procfs(5): proc /proc procfs rw 0 0 Therefore, I see no reason to change the package message only because the manual page says so. In fact, I think we should fix manual pages to be more consistent. Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201005191307.37338.jkim>