From nobody Wed Jul 29 17:50:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h9KcP1tsWz6mZsX for ; Wed, 29 Jul 2026 17:50:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h9KcN62F8z3mGP for ; Wed, 29 Jul 2026 17:50:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785347428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D2J1hnWGIkqRPpTJS43yNXAKrpUXE+MXWQ9pNO8YaCc=; b=iJG/eNuA0uzrK7lRhBKVp2aOnV4PeYwsNG9bXkZ8NwCK6gQY7oVCzGXdppkOpJg0X/pHcf aYoBX894AlWRUDUWZw/gHciEjdgj4nX5E5GFcbj6CSmRxh0Rm9LJ+9KzOOC+J97PRmbRJJ fYnJXRfN4S3ryw+JTXGiIiwfzTECBoRoLubl31UWNPmEE4iCXgs/SKPww331rds8b7U7Es klLBBZXk2T9xgxXc/tZMEubz8UQwM2DoFGyZrPntLoqSVFBMmRuKr9dVYAKr8UG6dLViIU tEWjd4KpXapwz/URWk7YtAsOJ9pQdjc8h1I7slg18jKFHR5l0nvqSdTLdLJSNg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785347428; a=rsa-sha256; cv=none; b=i34IuZVPAMdk1QQlgtrAmDrxK04aGO7lYXab3Lp7xo5vhCb4cyPUqrchhzkf+yxIUBRkfL 9GwxYoKDLDhBGf8wxmjchWad0h3u8jjfH5IS5xdDYwyDQsVcceamw9Rmv/81xTWdmOIu8n evC1EdCGZrRKzxFbDQMCpeBU8H6qh0pMjZKnmE0raRAoXA5E9XzD8teUTRDsTav425xlTY nRc5KiCGuJjnUB0tmkZETIpXJqf5XGX1o1QPyjWC/yqTmE1V5WymP3QhCQir1esaGLrKpB ZA/1uV51NjGv7rMfpjREO8CZC4+bf2CU9LCovt0BqbimT3kQKitrqBJ2sFJEYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785347428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D2J1hnWGIkqRPpTJS43yNXAKrpUXE+MXWQ9pNO8YaCc=; b=VnskXbbcuVG/9LJdEiOzqfi5cu5kW1nJ8VlUWop5isfu/fbh5Sq//I0tugDz1wMO2EmvOE PLCGpJvEq6oms7PTOpL1MAcI7tUstiHFNRdgCZ5/Rjq4Hcep+ooL3a4A8mHWQ2MbiOwtzr NcUMQrf+aZKWZxuYM5vdTgR8CkILySwtGWEMm70C8i3WiEpADn+zAKDwz6NaWCRJXNr+gu vOuV/LKLRBh6o3naWy6hYWuhtclfdDElR0xOttkYCZ9zQNc8LAHKD8gZeMHHHwSwnVcZu3 sdPW9A3giM9k5IQklshCVit8aHWg7stcnuwoDAek2DM9UoqavS+puHPv7AKcpg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h9KcN4g00zd9f for ; Wed, 29 Jul 2026 17:50:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ab65 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 29 Jul 2026 17:50:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 596030c13dce - releng/15.1 - zvol: Fix uses of uninitialized variables in zvol_rename_minors_impl() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.1 X-Git-Reftype: branch X-Git-Commit: 596030c13dce638f3cbaf89b19988f64f677cee5 Auto-Submitted: auto-generated Date: Wed, 29 Jul 2026 17:50:28 +0000 Message-Id: <6a6a3d64.3ab65.3e5c7375@gitrepo.freebsd.org> The branch releng/15.1 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=596030c13dce638f3cbaf89b19988f64f677cee5 commit 596030c13dce638f3cbaf89b19988f64f677cee5 Author: Mark Johnston AuthorDate: 2026-02-12 22:10:36 +0000 Commit: Mark Johnston CommitDate: 2026-07-28 15:16:03 +0000 zvol: Fix uses of uninitialized variables in zvol_rename_minors_impl() Reported-by: GitHub Copilot Reviewed-by: Brian Behlendorf Reviewed-by: Alexander Motin Signed-off-by: Mark Johnston Closes #18191 Approved by: so Security: FreeBSD-EN-26:19.zfs (cherry picked from commit 943a05528494b2f4585541089606796476fb229e) (cherry picked from commit 698e0c419895da2d0d12c5f4d61d85a1d91b6b9d) --- sys/contrib/openzfs/module/zfs/zvol.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/contrib/openzfs/module/zfs/zvol.c b/sys/contrib/openzfs/module/zfs/zvol.c index b35817f5c830..12f87c870eac 100644 --- a/sys/contrib/openzfs/module/zfs/zvol.c +++ b/sys/contrib/openzfs/module/zfs/zvol.c @@ -1762,6 +1762,7 @@ zvol_rename_minors_impl(zvol_task_t *task) if (zvol_inhibit_dev) return; + last_error = 0; oldnamelen = strlen(oldname); rw_enter(&zvol_state_lock, RW_WRITER); @@ -1781,6 +1782,8 @@ zvol_rename_minors_impl(zvol_task_t *task) zv->zv_name + oldnamelen + 1); error = zvol_os_rename_minor(zv, name); kmem_strfree(name); + } else { + error = 0; } if (error) { last_error = error;