Date: Wed, 26 Feb 2020 22:30:22 +0100 From: Andreas Kempe <kempe@lysator.liu.se> To: Hans Petter Selasky <hps@selasky.org> Cc: Konstantin Belousov <kib@freebsd.org>, Meny Yossefi <menyy@mellanox.com>, freebsd-infiniband@freebsd.org Subject: Re: [PATCH]: ipoib with mlx4 initialisation ordering Message-ID: <20200226213022.GG22659@moira.hest-guild.se> In-Reply-To: <e2bcedd2-f2db-4d5d-453f-b59f8d7e186e@selasky.org> References: <20200222004838.GA22659@moira.hest-guild.se> <9d76992b-6ba4-2419-61ff-5035aa45e597@selasky.org> <20200224194608.GC22659@moira.hest-guild.se> <16883d49-3cc0-d9cc-0877-46f811eeb8f1@selasky.org> <20200226210554.GE22659@moira.hest-guild.se> <e2bcedd2-f2db-4d5d-453f-b59f8d7e186e@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--/9ZOS6odDaRI+0hI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 26, 2020 at 10:08:09PM +0100, Hans Petter Selasky wrote: > On 2020-02-26 22:05, Andreas Kempe wrote: > > +module_exit_order(ipoib_cleanup_module, SI_ORDER_FIRST); >=20 > Try: >=20 > module_exit_order(ipoib_cleanup_module, SI_ORDER_FOURTH); >=20 Tried it, but the machine still hung. See patch: Index: sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c (revision 356611) +++ sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c (working copy) @@ -1739,7 +1739,7 @@ } =20 module_init(ipoib_init_module); -module_exit(ipoib_cleanup_module); +module_exit_order(ipoib_cleanup_module, SI_ORDER_FOURTH); =20 static int ipoib_evhand(module_t mod, int event, void *arg) >=20 > Fourth is first, >=20 > first is last. >=20 > for exit. >=20 I see I should read some more man pages. :P Cordially, Andreas Kempe --/9ZOS6odDaRI+0hI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEETci4cPcl+ZcyiACiCkqKrhcKSD0FAl5W42cACgkQCkqKrhcK SD2tUBAAqOkCSS4UKxsvPsHL6KgFfCp1cZZNdoGwzBJ09/M2qzwtUjAG7o5b40G5 UB1dUKzCp4Xj2luJE4kM2g2uOSlbU+YzYbgv8eZ+2Pr+XpyLKBBUUhiPLAhIcCmD 1e4RiYm1bGS/BLZXGCxSSphbKN141eryBrgF/Dbm5B0KbSWU+bC4m0U4xn99KVyc vT+8dl3zknv/nc5LRA2EziPa4uCzZNmW7ym6eMNjvOMhxIzFO+yf9KoXWCOjWO9i U4CMVh/Ft59MCXmToyauvCMuAAOpO4Keacz3gzEwIML8VtiLYr2BLJZWBTGILlh7 jhWSxYKGuQ0Yjui1ZCXliHal7ws91nfISXNlji4nFs4SbZdFYh1SzMma/jlbKeOq 9QaV75UJF6095P29tNhWUMonPYsN4x3tqPIP0cA9/991yrtfT+LQfJt5tZvWMOPH xVZgSo66eQ/c8gqufiu494C5+4+gbtMpGKQCkvZA2mLm3D0KtZJ0nA0rbxbpX2Dz H831RoO8LS22PP8oUa04rbU5ooJ9GimBXf8UrZymNUmW7KYJZEF3VMgSnAs9GFSu g1oJ2MY0BOH3NLi+y+0nJP89NpUqvLgmaJOPKD3QOfycNmCULY5t8t7H6kAfeDzF QiWkk60jRLThz/yLvHcfsRe89Xnc+monGmt6px8CnKR/Pa8vjD0= =CyZF -----END PGP SIGNATURE----- --/9ZOS6odDaRI+0hI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200226213022.GG22659>