From owner-svn-ports-all@FreeBSD.ORG Wed Jan 15 15:50:32 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A9F0360C; Wed, 15 Jan 2014 15:50:32 +0000 (UTC) Received: from mail-we0-x22c.google.com (mail-we0-x22c.google.com [IPv6:2a00:1450:400c:c03::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 77E831182; Wed, 15 Jan 2014 15:50:31 +0000 (UTC) Received: by mail-we0-f172.google.com with SMTP id q58so1987211wes.3 for ; Wed, 15 Jan 2014 07:50:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=T1ZLOaVz4yNAxXSpf9Cc/fRX48rYjFC3mNkm1qZ2PVs=; b=NioxfImXsVCMw5fB1jLSj2lThgiQTL5q88pdD0fnyIRND4aLQxCS172AsrOhUzXX/e WhnmYVRhqIsrhiSq2jJk9UbqS1axwr6PeIri65+TyCq0GpQuPwXRjgWLlSy/iJPJVQqe RaPtIwyal7zbVbMvbGP428FaF1f5J9J7sRtJqcHp7KsDeK+WUIpJrucn+KypakB9dIHH 2mMsADUD/P88NSaEX2oImAyApeIBHyJBNVGqfln/OzUuPfQB/LJksWAYSPzlp2tK3UmD dXHz0jBCppip5w19rFBNnH+Bl6j5P7WRETC5je6Aacyyc/JPEVOEizEyIoYkMtRmc8Ka QtMA== X-Received: by 10.180.108.240 with SMTP id hn16mr3009710wib.5.1389801029636; Wed, 15 Jan 2014 07:50:29 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id gd5sm28955796wic.0.2014.01.15.07.50.27 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 15 Jan 2014 07:50:28 -0800 (PST) Sender: Baptiste Daroussin Date: Wed, 15 Jan 2014 16:50:22 +0100 From: Baptiste Daroussin To: Steve Wills Subject: Re: svn commit: r339777 - head/lang/modula3 Message-ID: <20140115155022.GI77567@ithaqua.etoilebsd.net> References: <201401151341.s0FDfQ1M053094@svn.freebsd.org> <998760DE607B43BBDEA3C8AE@ogg.in.absolight.net> <20140115151820.GH77567@ithaqua.etoilebsd.net> <20140115154348.GA54731@mouf.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="16qp2B0xu0fRvRD7" Content-Disposition: inline In-Reply-To: <20140115154348.GA54731@mouf.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Mathieu Arnold , svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, John Marino , ports-committers@FreeBSD.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2014 15:50:32 -0000 --16qp2B0xu0fRvRD7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 15, 2014 at 03:43:49PM +0000, Steve Wills wrote: > On Wed, Jan 15, 2014 at 04:18:20PM +0100, Baptiste Daroussin wrote: > > On Wed, Jan 15, 2014 at 03:17:08PM +0100, Mathieu Arnold wrote: > > > +--On 15 janvier 2014 13:41:26 +0000 John Marino = wrote: > > > | lang/modula3: Not for FreeBSD 8.x > > > | =20 > > > | +. if !exists(/usr/include/xlocale/_ctype.h) > > > | +IGNORE=3D the bootstrap compiler only runs on FreeBSD 9.0 or later > > > | +. endif > > > | . endif > > >=20 > > > That should be .if ${OSVERSION} < 9000000 or something. > > >=20 > > > --=20 > > > Mathieu Arnold > >=20 > > It is better to test for the existence of a file as if some are creating > > custom images they without that file it will match anyway. > >=20 > > OSVERSION is a legacy from pointyhat/tinderbox time, now pointyhat is g= one and > > tinderbox knows how to check in the real destination target and not in = the host, > > lots of those OSVERSION can just die. >=20 > How would this work in the case of a change to a file that already exists= as > opposed to a file existing? Then testing the content of the file is the only safe way (that is what I d= o in compiler.mk) regards, Bapt --16qp2B0xu0fRvRD7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLWrj4ACgkQ8kTtMUmk6Ex0+wCfQVp6Ee/HZmPrTm8/bK7GTAyQ vkIAoKxBJZk+FOj18QHzW9gqVPwiDuiJ =gLzb -----END PGP SIGNATURE----- --16qp2B0xu0fRvRD7--