From owner-freebsd-current@FreeBSD.ORG Mon Jun 8 18:26:59 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C62601065673 for ; Mon, 8 Jun 2009 18:26:59 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from mx.egr.msu.edu (surfnturf.egr.msu.edu [35.9.37.164]) by mx1.freebsd.org (Postfix) with ESMTP id 9E2C68FC28 for ; Mon, 8 Jun 2009 18:26:59 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from localhost (localhost [127.0.0.1]) by mx.egr.msu.edu (Postfix) with ESMTP id 3952471F4C6; Mon, 8 Jun 2009 14:26:59 -0400 (EDT) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mx.egr.msu.edu ([127.0.0.1]) by localhost (surfnturf.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uALrDsEZxzas; Mon, 8 Jun 2009 14:26:59 -0400 (EDT) Received: from localhost (daemon.egr.msu.edu [35.9.44.65]) by mx.egr.msu.edu (Postfix) with ESMTP id 1787C71F4B2; Mon, 8 Jun 2009 14:26:58 -0400 (EDT) Received: by localhost (Postfix, from userid 21281) id CE8481AB; Mon, 8 Jun 2009 14:26:58 -0400 (EDT) Date: Mon, 8 Jun 2009 14:26:58 -0400 From: Adam McDougall To: Ed Schouten Message-ID: <20090608182658.GY12796@egr.msu.edu> References: <20090526213921.GD48776@hoeg.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090526213921.GD48776@hoeg.nl> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: FreeBSD Current Subject: Re: CFT: ee 1.5.0 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jun 2009 18:27:00 -0000 On Tue, May 26, 2009 at 11:39:21PM +0200, Ed Schouten wrote: Hi all, Some days ago Bruce Cran and I were talking on IRC about the ancient version of ee(1) we have in the tree. Today I spent some time moving ee(1) to contrib/ee with proper mergeinfo in place, to make it easier to upgrade it. It turns out all local modifications we have to ee(1) right now (line numbers, mktemp, etc) have been implemented upstream as well, in most cases even better. So I've decided to switch to an almost clean copy of ee(1). My patch so far (requires a very recent source tree): http://80386.nl/pub/ee-freebsd-1.5.0.diff Any comments before I commit this patch to SVN? After using the new ee in a -current build, it seems like an old issue has come back where if the containing xterm is resized, ee ungracefully exits without saving. I think it was fixed a while ago but a quick look at the modern ee.c seems to indicate this was lost: Revision 1.25: download - view: text, markup, annotated - select for diffs Sat Jul 28 22:40:10 2001 UTC (7 years, 10 months ago) by mp Branches: MAIN Diff to: previous 1.24: preferred, colored Changes since revision 1.24: +5 -10 lines Properly handle wgetch(3) returning ERR. This prevents an abnormal exit when a windows resize event (SIGWINCH) occurs. Reported by: John Doe and others on -stable. Reviewed by: dd MFC after: 1 week Also something else which I did not check on: Revision 1.26: download - view: text, markup, annotated - select for diffs Fri Aug 31 21:50:06 2001 UTC (7 years, 9 months ago) by mp Branches: MAIN Diff to: previous 1.25: preferred, colored Changes since revision 1.25: +2 -1 lines Exit gracefully when a SIGHUP is received. This prevents ee from going into an infinite spin loop when the terminal window is forcibly blown away. PR: 29553 Reported by: Sung N. Cho MFC after: 1 day Thanks. Let me know if I should do more to help.