From owner-svn-src-all@freebsd.org Sun Jul 31 20:16:18 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D390BBA9EDA; Sun, 31 Jul 2016 20:16:18 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mailhost.stack.nl", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 91E2D12A4; Sun, 31 Jul 2016 20:16:18 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mx1.stack.nl (Postfix) with ESMTP id 5D4B1358C66; Sun, 31 Jul 2016 22:16:15 +0200 (CEST) Received: by snail.stack.nl (Postfix, from userid 1677) id 3516928494; Sun, 31 Jul 2016 22:16:15 +0200 (CEST) Date: Sun, 31 Jul 2016 22:16:15 +0200 From: Jilles Tjoelker To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303586 - head/bin/sh Message-ID: <20160731201614.GA58505@stack.nl> References: <201607311311.u6VDBYr8066638@repo.freebsd.org> <20160731134316.GB85936@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160731134316.GB85936@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2016 20:16:18 -0000 On Sun, Jul 31, 2016 at 01:43:16PM +0000, Alexey Dokuchaev wrote: > On Sun, Jul 31, 2016 at 01:11:34PM +0000, Jilles Tjoelker wrote: > > New Revision: 303586 > > URL: https://svnweb.freebsd.org/changeset/base/303586 > > Log: > > sh: Fix a clang warning. > > Submitted by: bdrewery > > Modified: > > head/bin/sh/expand.c > > Modified: head/bin/sh/expand.c > > ============================================================================== > > --- head/bin/sh/expand.c Sun Jul 31 12:59:10 2016 (r303585) > > +++ head/bin/sh/expand.c Sun Jul 31 13:11:34 2016 (r303586) > > @@ -473,7 +473,8 @@ expbackq(union node *cmd, int quoted, in > > if (--in.nleft < 0) { > > if (in.fd < 0) > > break; > > - while ((i = read(in.fd, buf, sizeof buf)) < 0 && errno == EINTR); > > + while ((i = read(in.fd, buf, sizeof buf)) < 0 && errno == EINTR) > > + ; > `continue;' would be even better; some tools might barf at stray semicolon. Both continue; and ; (the latter with and without comment) occur in the source tree many times. I don't really like a continue that does nothing because it is at the end of a loop, so I prefer to make this whitespace change only (there are two more instances in bin/sh). I think a sole semicolon on a line is conspicuous enough that nothing additional is required. -- Jilles Tjoelker