From owner-svn-src-head@freebsd.org Fri Mar 3 06:52:47 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0399BCF4FFE; Fri, 3 Mar 2017 06:52:47 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.allbsd.org", Issuer "RapidSSL SHA256 CA - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 61F28123F; Fri, 3 Mar 2017 06:52:46 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail-d.allbsd.org (p2027-ipbf1605funabasi.chiba.ocn.ne.jp [123.225.191.27]) (authenticated bits=56) by mail.allbsd.org (8.15.2/8.15.2) with ESMTPSA id v236qMc9082619 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) (Client CN "/OU=GT07882699/OU=See+20www.rapidssl.com/resources/cps+20+28c+2915/OU=Domain+20Control+20Validated+20-+20RapidSSL+28R+29/CN=*.allbsd.org", Issuer "/C=US/O=GeoTrust+20Inc./CN=RapidSSL+20SHA256+20CA+20-+20G3"); Fri, 3 Mar 2017 15:52:42 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from alph.allbsd.org (alph.allbsd.org [192.168.0.10]) by mail-d.allbsd.org (8.15.2/8.15.2) with ESMTPS id v236p6iP075784 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 3 Mar 2017 15:51:06 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.allbsd.org (8.15.2/8.15.2) with ESMTPA id v236p5Wh075781; Fri, 3 Mar 2017 15:51:06 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Fri, 03 Mar 2017 15:49:55 +0900 (JST) Message-Id: <20170303.154955.607107599855581369.hrs@allbsd.org> To: ngie@FreeBSD.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314585 - head/usr.sbin/syslogd From: Hiroki Sato In-Reply-To: <201703030613.v236DxDl010255@repo.freebsd.org> References: <201703030613.v236DxDl010255@repo.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Fri_Mar__3_15_49_55_2017_040)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.99 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-4.4.3 (mail.allbsd.org [133.31.130.32]); Fri, 03 Mar 2017 15:52:43 +0900 (JST) X-Spam-Status: No, score=-99.9 required=13.0 tests=CONTENT_TYPE_PRESENT, QENCPTR1,USER_IN_WHITELIST autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on gatekeeper.allbsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 06:52:47 -0000 ----Security_Multipart(Fri_Mar__3_15_49_55_2017_040)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Ngie Cooper wrote in <201703030613.v236DxDl010255@repo.freebsd.org>: ng> Author: ngie ng> Date: Fri Mar 3 06:13:59 2017 ng> New Revision: 314585 ng> URL: https://svnweb.freebsd.org/changeset/base/314585 ng> ng> Log: ng> Correct verb change for service => `*` after r314563 ng> ng> `*` means that packets will be received from a remote peer on any port. ng> Since the point of interest is the syslogd instance (not the remote peer), ng> the appropriate verb is "received", not "sent". ng> ng> MFC after: 1 month ng> X-MFC with: r314563 ng> Sponsored by: Dell EMC Isilon ng> ng> Modified: ng> head/usr.sbin/syslogd/syslogd.8 ng> ng> Modified: head/usr.sbin/syslogd/syslogd.8 ng> ============================================================================== ng> --- head/usr.sbin/syslogd/syslogd.8 Fri Mar 3 06:06:27 2017 (r314584) ng> +++ head/usr.sbin/syslogd/syslogd.8 Fri Mar 3 06:13:59 2017 (r314585) ng> @@ -131,7 +131,7 @@ A ng> .Ar service ng> of ng> .Ql \&* ng> -allows packets to be sent from any UDP port. ng> +allows packets to be received from any UDP port. ng> The default ng> .Ar service It is incorrect that syslogd receives a UDP packet on any local port when a "*" is specified. This address validation is done by using the source port number in a received UDP packet, so the point of interest is the remote peer. How about "...accepts UDP packets sent with any source port" or something? -- Hiroki ----Security_Multipart(Fri_Mar__3_15_49_55_2017_040)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAli5EhMACgkQTyzT2CeTzy2dEQCfcCsCP+Z5JMF4RG2RzINgZ4ku 5ykAnR9GlOpj4ZyupUJzAjFstSCk6wyT =zhSm -----END PGP SIGNATURE----- ----Security_Multipart(Fri_Mar__3_15_49_55_2017_040)----