Date: Fri, 1 Jun 2018 16:20:27 +0000 (UTC) From: Mathieu Arnold <mat@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r471265 - head/Mk/Scripts Message-ID: <201806011620.w51GKRJg002836@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mat Date: Fri Jun 1 16:20:26 2018 New Revision: 471265 URL: https://svnweb.freebsd.org/changeset/ports/471265 Log: SC2068: Double quote array expansions to avoid re-splitting elements. Double quotes around $@ prevents globbing and word splitting of individual elements, while still expanding to multiple separate arguments. Add exceptions when splitting is the intended behavior. PR: 227109 Submitted by: mat Sponsored by: Absolight Modified: head/Mk/Scripts/depends-list.sh (contents, props changed) Modified: head/Mk/Scripts/depends-list.sh ============================================================================== --- head/Mk/Scripts/depends-list.sh Fri Jun 1 16:20:22 2018 (r471264) +++ head/Mk/Scripts/depends-list.sh Fri Jun 1 16:20:26 2018 (r471265) @@ -115,10 +115,14 @@ check_dep() { fi [ ${show_dep} -eq 1 ] && echo "${port_display}" if [ ${recursive} -eq 1 -o ${requires_wrkdir} -eq 1 -a ${show_dep} -eq 1 ]; then + # shellcheck disable=SC2068 + # Do not add quotes, we want to split the string here. check_dep $@ fi done } checked= +# shellcheck disable=SC2068 +# Do not add quotes, we want to split the string here. check_dep $@
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806011620.w51GKRJg002836>