Date: Wed, 20 May 2009 14:38:02 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: Andrew Thompson <thompsa@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Pyun YongHyeon <yongari@freebsd.org> Subject: Re: svn commit: r192418 - head/sys/dev/age Message-ID: <20090520053801.GG9043@michelle.cdnetworks.co.kr> In-Reply-To: <20090520052401.GL78829@citylink.fud.org.nz> References: <200905200333.n4K3XRKj017947@svn.freebsd.org> <20090520052401.GL78829@citylink.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 19, 2009 at 10:24:01PM -0700, Andrew Thompson wrote: > On Wed, May 20, 2009 at 03:33:27AM +0000, Pyun YongHyeon wrote: > > Author: yongari > > Date: Wed May 20 03:33:27 2009 > > New Revision: 192418 > > URL: http://svn.freebsd.org/changeset/base/192418 > > > > Log: > > pci(4) handles PCIM_CMD_INTxDIS so there is no need to poke this > > bit in driver. > > > > Modified: > > head/sys/dev/age/if_age.c > > > > Modified: head/sys/dev/age/if_age.c > > ============================================================================== > > --- head/sys/dev/age/if_age.c Wed May 20 03:28:35 2009 (r192417) > > +++ head/sys/dev/age/if_age.c Wed May 20 03:33:27 2009 (r192418) > > @@ -1477,23 +1477,11 @@ age_resume(device_t dev) > > { > > struct age_softc *sc; > > struct ifnet *ifp; > > - uint16_t cmd; > > > > sc = device_get_softc(dev); > > > > AGE_LOCK(sc); > > - /* > > - * Clear INTx emulation disable for hardwares that > > - * is set in resume event. From Linux. > > - */ > > - cmd = pci_read_config(sc->age_dev, PCIR_COMMAND, 2); > > - if ((cmd & 0x0400) != 0) { > > - cmd &= ~0x0400; > > - pci_write_config(sc->age_dev, PCIR_COMMAND, cmd, 2); > > - } > > - AGE_UNLOCK(sc); > > age_phy_reset(sc); > > - AGE_LOCK(sc); > > ifp = sc->age_ifp; > > age_phy_reset() was previously called unlocked and is now the opposite, > is this intended? > Yes, age_phy_reset() used to call pause(9) but the call was removed.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090520053801.GG9043>