From owner-svn-src-head@freebsd.org Sun Jun 17 15:53:16 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8476B1023950 for ; Sun, 17 Jun 2018 15:53:16 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 21FF47320A for ; Sun, 17 Jun 2018 15:53:16 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from mail-yb0-f179.google.com (mail-yb0-f179.google.com [209.85.213.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: eadler) by smtp.freebsd.org (Postfix) with ESMTPSA id DFAE6B47B for ; Sun, 17 Jun 2018 15:53:15 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: by mail-yb0-f179.google.com with SMTP id m137-v6so5146719ybm.6 for ; Sun, 17 Jun 2018 08:53:15 -0700 (PDT) X-Gm-Message-State: APt69E12nMNGvkSZeHrT+fl6sKlqnUvswUsrSWl/Shhp8qQHOxnxMiG2 VmPuXTI+H28IoQgdJhHmgAJSzOLAdoQ/xN+2A4oeRg== X-Google-Smtp-Source: ADUXVKJOlB9SxcDfO+LPeBttIo2hyMMw4EbckLgv9eqxNMb5beQVr/qyhSrMNEChtMKr2PYU4FSqT1G1vro+Z3/woEs= X-Received: by 2002:a25:2605:: with SMTP id m5-v6mr4852975ybm.89.1529250795352; Sun, 17 Jun 2018 08:53:15 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Sun, 17 Jun 2018 08:52:44 -0700 (PDT) In-Reply-To: <1529250589.20460.19.camel@freebsd.org> References: <201806170315.w5H3FHOD058428@pdx.rh.CN85.dnsmgr.net> <201806171507.w5HF7gdT060646@pdx.rh.CN85.dnsmgr.net> <1529250589.20460.19.camel@freebsd.org> From: Eitan Adler Date: Sun, 17 Jun 2018 08:52:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r335270 - head/lib/liby To: Ian Lepore Cc: Juli Mallett , "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 15:53:16 -0000 On 17 June 2018 at 08:49, Ian Lepore wrote: > All this drama about "copying" one line of text and adding another to > create a new file. The no-brainer fix is to add a proper new-file > license and stop arguing about what flavor of copying and what rules > might apply to that. I didn't add my copyright since I didn't write it. I'll rewrite from scratch and add my own new-file copyright. This file contains precisely zero creative output [0] so it should't matter too much. > And for something that might actually matter: nobody seems to have > noticed that this new header file lacks the standard include guards > (something which style(9) seems to be silent about). Good point. [0] Oracle v Google notwithstanding -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams