From nobody Thu Sep 19 13:03:38 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X8bLN0YPkz5WY94 for ; Thu, 19 Sep 2024 13:03:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X8bLM51pKz4rpG for ; Thu, 19 Sep 2024 13:03:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726751019; a=rsa-sha256; cv=none; b=PJIm8Rw72+Qx6zbDv7bz7vPUj5As2+lso3qjRdKpzsJfgB/bNUgQZyZBe1nzNittzWIs21 k66uObopSrH85WFgj+ymXk3t6z0oBLfPXfno1qouv9wRuTN2CMWMe1PhJV6y+o7SQct8/o 0t67pyI2Dl2QI+MeRJhQoQCw7AYJNtgn+2PGhCugLfVZPohbztWtgYxEKbEG4tJack72Ci fl+IvmqVfaqvtlVQ/+26s+wWWHaZw/GTx61GFc24zJPkl3lnJTdH5nMbKZ2USh1HK4Ocj5 /eGa45nTHletyBkpkhHMVkK+ze4KREBVNT0IyqK6iXoKGahWTE/IQyKxx/FwVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726751019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lsDqSljsjEa9isvMxai/DQn4BFRFBk0aveXAHBgEE/E=; b=AyUjxG92NGVVil3KP6mMyoObQLPpneNBT6p7Ut+TZ7PQ17qAyD69eYTjoiTKTTdAzUdzWk vN1L0xltkx+aMZ4Lg5LGFvirx/yyjLmnpff1FUQ0eQWFDTBjNPD0vv8ljXPCuuZBLrTYU3 d+Uj61rLEv0vP2a4rU0Ss7/HUKLzyVd2AiZ2GA+hefCwBI4b9gH1xxyiX2ZJFZwLHf230B 8TcpRDKROuyFcg0HjIiDt65zf05uEZplLWZWajezEo3rPhp8wYT6/kMcpI6zAVp4VZsZqU dXjPJHdP334+RysJ8UwAX/i5cSO4LSMXu8/fEU3GBwUOTiXywRgBf/irP7O8uw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4X8bLM4dTQz15pP for ; Thu, 19 Sep 2024 13:03:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 48JD3d1j085929 for ; Thu, 19 Sep 2024 13:03:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 48JD3dIq085928 for net@FreeBSD.org; Thu, 19 Sep 2024 13:03:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute) Date: Thu, 19 Sep 2024 13:03:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.1-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280701 --- Comment #87 from commit-hook@FreeBSD.org --- A commit in branch releng/14.1 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dfb925cf0a4b38bffc4c9733bae3212f07= a481931 commit fb925cf0a4b38bffc4c9733bae3212f07a481931 Author: Kristof Provost AuthorDate: 2024-08-12 14:07:35 +0000 Commit: Mark Johnston CommitDate: 2024-09-19 12:54:47 +0000 pf: fix icmp-in-icmp state lookup In 534ee17e6 pf state checking for ICMP(v6) was made stricter. This cha= nge failed to correctly set the pf_pdesc for ICMP-in-ICMP lookups, resultin= g in ICMP error packets potentially being dropped incorrectly. Specially, it copied the ICMP header into a separate variable, not into= the pf_pdesc. Populate the required pf_pdesc fields for the embedded ICMP packet's st= ate lookup. Approved by: so Security: FreeBSD-EN-24:16.pf PR: 280701 MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit 2da98eef1f352c496ffd458b4c68ddee972bb903) (cherry picked from commit 27a1a56b0d2e6ffa6ab1de69ef84fe66b7fd41e0) sys/netpfil/pf/pf.c | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=