From owner-svn-ports-head@freebsd.org Fri Oct 7 07:06:48 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14937BECECC; Fri, 7 Oct 2016 07:06:48 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A9C5B1AE; Fri, 7 Oct 2016 07:06:47 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 49BEEBDCC8; Fri, 7 Oct 2016 09:06:46 +0200 (CEST) Received: from atuin.in.mat.cc (48.196.7.109.rev.sfr.net [109.7.196.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id CB60CBDCAC; Fri, 7 Oct 2016 09:06:44 +0200 (CEST) Subject: Re: svn commit: r423434 - head/security/openssl To: Bernard Spil , Joseph Mingrone References: <201610061938.u96JcmrW038201@repo.freebsd.org> <861szsvni2.fsf@phe.ftfl.ca> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: <4966323d-be0f-2e44-22df-4645779fd28f@FreeBSD.org> Date: Fri, 7 Oct 2016 09:06:40 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LJMugC8hfUbH43fxdPJgRAxKJxhqFPOwu" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 07:06:48 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LJMugC8hfUbH43fxdPJgRAxKJxhqFPOwu Content-Type: multipart/mixed; boundary="0xcSWaQCc67NajeA7G0VV7wsiuwCUn7Lm"; protected-headers="v1" From: Mathieu Arnold To: Bernard Spil , Joseph Mingrone Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <4966323d-be0f-2e44-22df-4645779fd28f@FreeBSD.org> Subject: Re: svn commit: r423434 - head/security/openssl References: <201610061938.u96JcmrW038201@repo.freebsd.org> <861szsvni2.fsf@phe.ftfl.ca> In-Reply-To: --0xcSWaQCc67NajeA7G0VV7wsiuwCUn7Lm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 07/10/2016 =C3=A0 08:38, Bernard Spil a =C3=A9crit : > On 2016-10-07 5:36, Joseph Mingrone wrote: >> Mathieu Arnold writes: >> >>> Le 06/10/2016 =C3=A0 21:38, Bernard Spil a =C3=A9crit : >>>> Author: brnrd >>>> Date: Thu Oct 6 19:38:48 2016 >>>> New Revision: 423434 >>>> URL: https://svnweb.freebsd.org/changeset/ports/423434 >> >>>> Log: >>>> security/openssl: Fix ldconfig issue >> >>>> - OPT_USE=3D feature does not behave as expected >> >>> I strongly disagree with that comment, the opt_USE works exactly as >>> expected, and as documented. >> >> If I am understanding the documentation correctly >> >> OPT_USE=3D ldconfig=3D${PREFIX}/lib/blah/lib >> >> should add ${PREFIX}/lib/blah/lib to ${LOCALBASE}/libdata/ldconfig/bla= h. >> >> I just tested and it is not creating >> ${LOCALBASE}/libdata/ldconfig/blah when OPT is on. >> >> The code below does. >> >> .if ${PORT_OPTIONS:MOPT} >> USE_LDCONFIG=3D ${PREFIX}/lib/blah/lib >> .endif > > Hi Joseph, > > That's another issue which is specific to using ${PREFIX} at this stage= =2E > When I set > SHARED_USE=3D ldconfig=3D${PREFIX}/lib/blah > > $ make -VUSE_LDCONFIG > /lib/blah > as ${PREFIX} isn't set during options processing Try the patch in https://reviews.freebsd.org/D8169. > I was just looking for the default behavior here. Setting SHARED_USE=3D= > ldconfig results in > $ make -VUSE_LDCONFIG > ldconfig > > for lack of an `=3D' character in the SHARED_USE value. I have created > D8166 that simply sets USE_FEATURE=3D yes when no `=3D' is present in > OPT_USE=3D feature. I don't really like that, it should be either an error, or be ignored, there are not a lot of USE_ where a yes value makes sense. --=20 Mathieu Arnold --0xcSWaQCc67NajeA7G0VV7wsiuwCUn7Lm-- --LJMugC8hfUbH43fxdPJgRAxKJxhqFPOwu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJX90mBXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IrXsP/1dYiEij9SazzAvJ+3NHih42 a38gMk/422XxY1k7JPvtshmrCbSXI1CIALeGlRuv+vcrmFz+kWC05SVE/+LpE6/d JIJ5lDpPAoPTIRM3O9PCx+cPUiqzSTnrUQsjOAxPB9sF56ENVjxZTGx3LmO/aA3y G+qCA5v+1dILsnb+L4qUh0mvvfxBQ3Pvo8AKmyoImX/IClC0Hbo7LJz0o+OZ2NuP maUAAia/EcC0JYdExMfHWrkDDt4dla0JVjh+nIiERGVDUQeAb06+TO73spPpSokf Ah3HpEiKUcE17xBf1+eQk+zQnVYkTfiqNKO7gnR2MlUhymdcVldbN1YrY4w+ksj1 FfCyba8lyzlbzx++Dvg8FxrYa5veWw2tK/wb3x7Zt0f7xNJBYP20ABWegIHo62Kr VaRkV9y90WwWKE2+NfXdS4PEs8KULYQz+udKpWl6Hibt0ZaISOhOn/f0N5H2agnA rUubUaXNsCfKqwAmxkwSP7XUsRCas6tbfR6cmhwmz6NtnpbK3vFGVlTLnMdhhA4e HGV75XDJPzh0V1idurh9IKGottbJHP6jEhwAtrig3q6DTmE48KAMr70HyE+yCsdT ShkguDdanhCfCii78Ynj0OM6DJ4zuut6IxYOn2AtFwdOUmmwU+oms3yuc8SJTOVi syMNzq50s709T4s+oNfn =BFQs -----END PGP SIGNATURE----- --LJMugC8hfUbH43fxdPJgRAxKJxhqFPOwu--