From owner-p4-projects@FreeBSD.ORG  Sat Aug 16 16:35:34 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1F46C1065673; Sat, 16 Aug 2008 16:35:34 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D77BA1065671
	for <perforce@freebsd.org>; Sat, 16 Aug 2008 16:35:33 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outD.internet-mail-service.net (outd.internet-mail-service.net
	[216.240.47.227])
	by mx1.freebsd.org (Postfix) with ESMTP id B879D8FC14
	for <perforce@freebsd.org>; Sat, 16 Aug 2008 16:35:33 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id EF59B2470;
	Sat, 16 Aug 2008 09:35:33 -0700 (PDT)
Received: from julian-mac.elischer.org (localhost [127.0.0.1])
	by idiom.com (Postfix) with ESMTP id 1B2B52D606E;
	Sat, 16 Aug 2008 09:35:32 -0700 (PDT)
Message-ID: <48A701D2.5050004@elischer.org>
Date: Sat, 16 Aug 2008 09:35:30 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707)
MIME-Version: 1.0
To: Marko Zec <zec@FreeBSD.org>
References: <200808161256.m7GCuZS9012842@repoman.freebsd.org>
In-Reply-To: <200808161256.m7GCuZS9012842@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 147532 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Aug 2008 16:35:34 -0000

Marko Zec wrote:
> http://perforce.freebsd.org/chv.cgi?CH=147532
> 
> Change 147532 by zec@zec_tpx32 on 2008/08/16 12:56:28
> 
> 	Looks like I was a bit hasty with change 147531.  ip_newid()
> 	is an inline defined in ip_var.h, so whereever it is used in
> 	the code, definitions from sys/vimage.h are required.  So,
> 	instead of reverting back to pre-147531, #include sys/vimage.h
> 	once from netinet/ip_var.h, instead of having it in included
> 	individually from a multitude of affected .c files.
> 	of .
> 

I was considering doing this, or possibly changing ip_newid()
to not need it.

> Affected files ...
> 
> .. //depot/projects/vimage-commit2/src/sys/netinet/ip_var.h#3 edit
> 
> Differences ...
> 
> ==== //depot/projects/vimage-commit2/src/sys/netinet/ip_var.h#3 (text+ko) ====
> 
> @@ -34,6 +34,7 @@
>  #define	_NETINET_IP_VAR_H_
>  
>  #include <sys/queue.h>
> +#include <sys/vimage.h>
>  
>  /*
>   * Overlay for ip header used by other protocols (tcp, udp).