From owner-svn-src-head@freebsd.org Sun Oct 1 21:02:32 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B8D6E2E86C; Sun, 1 Oct 2017 21:02:32 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-lf0-x236.google.com (mail-lf0-x236.google.com [IPv6:2a00:1450:4010:c07::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 84DBA6EFD1; Sun, 1 Oct 2017 21:02:31 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-lf0-x236.google.com with SMTP id q132so4112299lfe.5; Sun, 01 Oct 2017 14:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gbCZnClSlV7ozhSwXAuvecrYNSb8saTHnvYHLQ9C7gM=; b=I4qfTXADn4hmG8Yigid8kIuxtx4QCbGmLdHroYrPScU3IDLd0KIrlx2Ly5oxdcV5Ad x3qAuAqdkJiv8lIGTP2t+Oy9LXWQjVowcQqnae6VePa+EavPYBmchYFonacZqK/UNrDi vudfmJ5XbXyeqTu1nJz+uiBB7zUSNk9i+eT62bk1rbRbwcFo0FyxZmATCaMIQhfvP8kO pjI2cjxN7XRV4uKM/tZrZHq+l07fYczY6sD30FepjXRNkYwDlUzFl8LiYASG0abQGdwj RIMh7+R/HiqnWFsbYCBM4of2dyV03dEESmE2IFkui3Vnl29rWgR/iSZUJXNG+Q/CQ0qP YcTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gbCZnClSlV7ozhSwXAuvecrYNSb8saTHnvYHLQ9C7gM=; b=R/aazezYmvhSk5oeZyDSd4hEhbBeJTawVSUJFsVIdbDSdApmXshqd+OLNB3m1OM+Zo QjQSNY+7Hy5ETy0b5LyMWtDLy+b18qwhiicYnifkDWTrzODbGLr2gAnIjwpzeP2gqfsO 3UrlxiXUE0PVsGUt73l2eRR6RmugWKt9oljKWjW+ijsfrgqsIp7uZKHr7cAUpNP1L0DE 8qLe/Cj9P1nMnRWDlfHQI6Bd4V1GA7j9y4MOPZVGKb61exqHDsHbPn+4STis/j/jukVJ JpludEhHGveX6nq4oz8XdE9bD1YFDmw3FkwAlFtGw9F3DoK+nJrOKlbd5d0CVVeK3MG8 fY1A== X-Gm-Message-State: AHPjjUjbLjDc39DCB0jE9/gcjrS6+eHBUyniLLQLwpf6FlcLSiwi5HDq w8bKpo7y1R4umWxjL1lfjSra86Tx0CzCZUFUnno= X-Google-Smtp-Source: AOwi7QCTHheGYr7Zm2gm/w0q7pHl4ORDNlLDHmZVbadTAnC2yI6GErhW2fMUYJGNXPAIDrmBcReHgyTVSS4UZfL+v/I= X-Received: by 10.46.70.18 with SMTP id t18mr6163302lja.31.1506891749183; Sun, 01 Oct 2017 14:02:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.86.77 with HTTP; Sun, 1 Oct 2017 14:02:28 -0700 (PDT) Received: by 10.46.86.77 with HTTP; Sun, 1 Oct 2017 14:02:28 -0700 (PDT) In-Reply-To: <1506890869.22078.45.camel@freebsd.org> References: <201710012012.v91KCUvU024559@repo.freebsd.org> <20171001223707.574cde55@thor.intern.walstatt.dynvpn.de> <1506890869.22078.45.camel@freebsd.org> From: Justin Hibbits Date: Sun, 1 Oct 2017 16:02:28 -0500 Message-ID: Subject: Re: svn commit: r324178 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua To: Ian Lepore Cc: Andriy Gapon , svn-src-head@freebsd.org, svn-src-all@freebsd.org, "O. Hartmann" , src-committers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2017 21:02:32 -0000 On Oct 1, 2017 15:48, "Ian Lepore" wrote: On Sun, 2017-10-01 at 22:37 +0200, O. Hartmann wrote: > Am Sun, 1 Oct 2017 20:12:30 +0000 (UTC) > Andriy Gapon schrieb: > > > > > Author: avg > > Date: Sun Oct 1 20:12:30 2017 > > New Revision: 324178 > > URL: https://svnweb.freebsd.org/changeset/base/324178 > > > > Log: > > unbreak kernel builds on sparc64 and powerpc after r324163, ZFS > > Channel Programs > > > > The custom iscntrl() in ZFS Lua code expects a signed argumnet, > > so > > remove the harmful cast. > > > > Reported by: ian > > MFC after: 5 weeks > > X-MFC with: r324163 > > > > Modified: > > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > > > > Modified: > > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > > =================================================================== > > =========== > > --- > > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > > Sun Oct 1 > > 19:52:47 2017 (r324177) +++ > > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > > Sun Oct 1 > > 20:12:30 2017 (r324178) @@ -867,7 +867,7 @@ static void > > addquoted (lua_State *L, > > luaL_Buffer *b, i luaL_addchar(b, '\\'); luaL_addchar(b, *s); > > } > > - else if (*s == '\0' || iscntrl(uchar(*s))) { > > + else if (*s == '\0' || iscntrl(*s)) { > > char buff[10]; > > if (!isdigit(uchar(*(s+1)))) > > sprintf(buff, "\\%d", (int)uchar(*s)); > > _______________________________________________ > > svn-src-head@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd. > > org" > The build of world fails for me with the error shown below: > > > [...] > Building /usr/obj/usr/src/cddl/lib/libzpool/lapi.o > --- lstrlib.o --- > /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > :114:12: warning: > implicitly declaring library function 'tolower' with type 'int > (int)' [-Wimplicit-function-declaration] p[i] = tolower(uchar(s[i])); > ^ > /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > :114:12: note: > include the header or explicitly provide a declaration for > 'tolower' > /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua/lstrlib.c > :127:12: > warning: implicitly declaring library function 'toupper' with type > 'int > (int)' [-Wimplicit-function-declaration] p[i] = toupper(uchar(s[i])); > > Also, removing the cast won't really be a fix on a platform that has default unsigned chars (which arm does, but arm doesn't use gcc; not sure about other platforms). -- Ian PowerPC uses unsigned char by default. - Justin