From owner-svn-src-all@freebsd.org  Fri Apr  6 01:29:33 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA063F9361F;
 Fri,  6 Apr 2018 01:29:33 +0000 (UTC)
 (envelope-from allanjude@freebsd.org)
Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 661277C0A7;
 Fri,  6 Apr 2018 01:29:33 +0000 (UTC)
 (envelope-from allanjude@freebsd.org)
Received: from [10.1.1.2] (Seawolf.HML3.ScaleEngine.net [209.51.186.28])
 (Authenticated sender: allanjude.freebsd@scaleengine.com)
 by mx1.scaleengine.net (Postfix) with ESMTPSA id A17F014B2F;
 Fri,  6 Apr 2018 01:29:32 +0000 (UTC)
Subject: Re: svn commit: r332070 - in head/sys/geom: . label raid
To: cem@freebsd.org
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201804051356.w35Duexg022529@repo.freebsd.org>
 <4cd9a49c-2d75-bfac-20df-72e8c80eded4@freebsd.org>
 <CAG6CVpXjmyZ-gfJh+vkzsOQOyu8k5sxL_RgzX4k_pdRPWSuyWA@mail.gmail.com>
From: Allan Jude <allanjude@freebsd.org>
Message-ID: <bf72fc9c-c3a7-da5c-d295-c28d16241209@freebsd.org>
Date: Thu, 5 Apr 2018 21:29:40 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CAG6CVpXjmyZ-gfJh+vkzsOQOyu8k5sxL_RgzX4k_pdRPWSuyWA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2018 01:29:33 -0000

On 2018-04-05 21:20, Conrad Meyer wrote:
> On Thu, Apr 5, 2018 at 6:08 PM, Allan Jude <allanjude@freebsd.org> wrote:
>> On 2018-04-05 09:56, Sean Bruno wrote:
>>> Author: sbruno
>>> Date: Thu Apr  5 13:56:40 2018
>>> New Revision: 332070
>>> URL: https://svnweb.freebsd.org/changeset/base/332070
>>>
>>> Log:
>>>   Squash error from geom by sizing ident strings to DISK_IDENT_SIZE.
>>>
>>> ...
>> I might be missing something here, but it seems like you didn't actually
>> change the side of
>> ...
>> struct md_s
> 
> The md side can be as small as it likes.  It's the caller who needs to
> provide the large buffer, for other providers of the GEOM::ident
> attribute.
> 
>> And I don't see where the destination buffer went from 24 bytes to a
>> larger value.
> 
> Check the change in md_intel.c.
> 
> Best,
> Conrad
> 

Right, but md_intel.c is for intel BIOS raid.

I don't see the change that increased the size of the buffer in the
caller from 24 bytes to something more useful?

Or was it md_intel tasting the md(4) device?

-- 
Allan Jude