From owner-cvs-all@FreeBSD.ORG Sun Jul 3 01:10:06 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E1A0F16A888; Sun, 3 Jul 2005 00:58:33 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 824E944658; Sun, 3 Jul 2005 00:42:35 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 763E66DCA8; Sat, 2 Jul 2005 17:38:09 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id C2CEE5C9AA for ; Tue, 25 Jan 2005 01:28:33 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 7B913565EF for ; Tue, 25 Jan 2005 09:28:33 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id E27B716A4F4; Tue, 25 Jan 2005 09:28:29 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 0868116A4D1; Tue, 25 Jan 2005 09:28:28 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D66BA16A4CE; Tue, 25 Jan 2005 09:28:26 +0000 (GMT) Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2FFC943D39; Tue, 25 Jan 2005 09:28:26 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j0P9SLUB079411; Tue, 25 Jan 2005 10:28:21 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Jeff Roberson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 25 Jan 2005 04:24:18 EST." <20050125042317.D18864@mail.chesapeake.net> Message-ID: <79410.1106645301@critter.freebsd.dk> Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern imgact_elf.c kern_descrip.c kern_exec.c uipc_syscalls.c vfs_bio.c vfs_subr.c vfs_syscalls.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:10:07 -0000 X-Original-Date: Tue, 25 Jan 2005 10:28:21 +0100 X-List-Received-Date: Sun, 03 Jul 2005 01:10:07 -0000 In message <20050125042317.D18864@mail.chesapeake.net>, Jeff Roberson writes: > >On Tue, 25 Jan 2005, Poul-Henning Kamp wrote: > >> phk 2005-01-25 00:39:00 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/kern imgact_elf.c kern_descrip.c kern_exec.c >> uipc_syscalls.c vfs_bio.c vfs_subr.c >> vfs_syscalls.c >> Log: >> Don't use VOP_GETVOBJECT, use vp->v_object directly. > >How does this effect stacking? Originally this was done so we could get >the appropriate level of vnode object. Was this discussed somewhere that >I missed? It was discussed on arch@ recently. Short summary: Instead of the code which calls VOP_OPEN being responsible for vnode_pager object creation it is now the vnode's own filesystem which must do so in vop_open() (and vfs_fhtovp() if exportable). This also shaved 200 lines of code out. Stacking filesystems do this, for instance nullfs sets v_object to that of the lower filesystem in vop_open() and sets it to NULL in vop_close(). That way vp->v_object can be used directly. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.