Date: Fri, 21 Nov 2014 17:39:43 +0000 From: Olivier Duchateau <olivierd@freebsd.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r371699 - head/shells/mksh Message-ID: <20141121173943.64c4c7ea64e5cdaec3bf50e5@freebsd.org> In-Reply-To: <20141121133045.GD12628@ivaldir.etoilebsd.net> References: <201410291949.s9TJn0sh019321@svn.freebsd.org> <20141119124113.GQ48896@ivaldir.etoilebsd.net> <20141121115534.bd0fd2ad78b8cd28ac5dfda2@freebsd.org> <20141121110304.GA48896@ivaldir.etoilebsd.net> <20141121133944.90e94e3c320ee5eff9e2db48@freebsd.org> <20141121133045.GD12628@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 21 Nov 2014 14:30:46 +0100 Baptiste Daroussin <bapt@FreeBSD.org> wrote: > On Fri, Nov 21, 2014 at 01:39:44PM +0000, Olivier Duchateau wrote: > > On Fri, 21 Nov 2014 12:03:04 +0100 > > Baptiste Daroussin <bapt@FreeBSD.org> wrote: > > > > > On Fri, Nov 21, 2014 at 11:55:34AM +0000, Olivier Duchateau wrote: > > > > On Wed, 19 Nov 2014 13:41:13 +0100 > > > > Baptiste Daroussin <bapt@FreeBSD.org> wrote: > > > > > > > > > On Wed, Oct 29, 2014 at 07:49:00PM +0000, Olivier Duchateau wrote: > > > > > > Author: olivierd > > > > > > Date: Wed Oct 29 19:49:00 2014 > > > > > > New Revision: 371699 > > > > > > URL: https://svnweb.freebsd.org/changeset/ports/371699 > > > > > > QAT: https://qat.redports.org/buildarchive/r371699/ > > > > > > > > > > > > Log: > > > > > > - Update to R50d > > > > > > - Drop @dirrm in pkg-plist > > > > > > > > > > > > PR: 194232 > > > > > > Submitted by: myself > > > > > > Approved by: @miwi (maintainer, timeout) > > > > > > > > > > > > Modified: > > > > > > head/shells/mksh/Makefile > > > > > > head/shells/mksh/distinfo > > > > > > head/shells/mksh/pkg-plist > > > > > > > > > > > > Modified: head/shells/mksh/Makefile > > > > > > ============================================================================== > > > > > > --- head/shells/mksh/Makefile Wed Oct 29 19:41:40 2014 (r371698) > > > > > > +++ head/shells/mksh/Makefile Wed Oct 29 19:49:00 2014 (r371699) > > > > > > @@ -2,7 +2,7 @@ > > > > > > # $FreeBSD$ > > > > > > > > > > > > PORTNAME= mksh > > > > > > -DISTVERSION= R50 > > > > > > +DISTVERSION= R50d > > > > > > > > > > This goas backward in history and needs to be adapter to the freebsd scheme: > > > > > $ pkg version -t r50 r50d > > > > > > > > > > > $ pkg version -t r50 r50.d > > > > > > > > > > > > > > > > No user will notice that as an upgrade. > > > > > > > > Even if I add PORTEPOCH, for the next releases problem still persists. > > > > > > > > Thorsten Glaser uses lower letter like minor version (usually a, b, c or d). Scheme is quite simple. > > > > For example: > > > > R50, next release is R50a and so on (up to c or d). > > > > > > > > So if we use PORTEPOCH > > > > pkg version -t r50 r50.d,1 > > > > < > > > > > > > > It's ok > > > > > > > > But the next stable release R51, > > > > pkg version -t r50.d,1 r51 > > > > > > > > > > > > > Normally R51 is greater than R50d, not here. > > > > > > > > I don't known how to solve this problem. > > > > > > > > > > pkg version -t 50d 50 > > > > > > > pkg version -t 50d 51 > > > < > > > > > > So I would propose: > > > PORTVERSION= 50d > > > DISTVERSIONPREFIX= R > > > > > > What do you think? > > > > Tested, I agree. > > > > PORTREVISION is necessary in this case? > > > Yes because DISTVERSION will turn 50d into 50.d which is lower than 50 :) Thanks, committed. > > regards, > Bapt -- olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141121173943.64c4c7ea64e5cdaec3bf50e5>