From owner-cvs-all@FreeBSD.ORG Fri Apr 16 04:31:39 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2E57B16A4CE for ; Fri, 16 Apr 2004 04:31:39 -0700 (PDT) Received: from hanoi.cronyx.ru (hanoi.cronyx.ru [144.206.181.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1CDE343D39 for ; Fri, 16 Apr 2004 04:31:38 -0700 (PDT) (envelope-from rik@cronyx.ru) Received: (from root@localhost) by hanoi.cronyx.ru id i3GBT6LS033664 for cvs-all@FreeBSD.ORG.checked; (8.12.8/vak/2.1) Fri, 16 Apr 2004 15:29:06 +0400 (MSD) (envelope-from rik@cronyx.ru) Received: from cronyx.ru (hi.cronyx.ru [144.206.181.94]) by hanoi.cronyx.ru with ESMTP id i3GBRw6J033579; (8.12.8/vak/2.1) Fri, 16 Apr 2004 15:27:58 +0400 (MSD) (envelope-from rik@cronyx.ru) Message-ID: <407FC333.6000901@cronyx.ru> Date: Fri, 16 Apr 2004 15:27:47 +0400 From: Roman Kurakin User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031208 X-Accept-Language: en-us, en MIME-Version: 1.0 To: =?UTF-8?B?U8O4cmVuIFNjaG1pZHQ=?= References: <20040413094519.7230616A4DB@hub.freebsd.org> <20040415162313.S92883@root.org> <407F9CB7.3020407@DeepCore.dk> In-Reply-To: <407F9CB7.3020407@DeepCore.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit cc: cvs-src@FreeBSD.ORG cc: =?UTF-8?B?77+9?= cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Nate Lawson Subject: Re: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-card.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Apr 2004 11:31:39 -0000 Søren Schmidt wrote: >> Includes fixes to avoid checking the ATA_FLAG_54_58 bit, fixing LBA >> detection: >> Submitted by: rk > > not true, rk submitted the problem not the code. Probably you are talking about me "rik" :-) I realy doesn't submit any code. I just tell my suggestions that checking this bit is bad idea according to ata spec, and according last ata specs it shouldn't be used at all since it obsoleted. So I didn't submit any fixes about it. Only idea. So this may be "Asked by" or "Pointed by" :-) Code I submitted was to make ata driver more verbose about CHS mode. They still are not there and should be revised to make them possible to apply to current code. By the way, may be it would be a nice idea to warn users that they have ATA_FLAG_54_58 bit off, and device will work in LBA mode not in CHS as was before? rik