From owner-p4-projects@FreeBSD.ORG  Thu Aug 16 14:08:45 2012
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id AA6EE1065672; Thu, 16 Aug 2012 14:08:44 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 583C5106564A
	for <perforce@freebsd.org>; Thu, 16 Aug 2012 14:08:44 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
	[IPv6:2001:4f8:fff6::2d])
	by mx1.freebsd.org (Postfix) with ESMTP id 41FE48FC14
	for <perforce@freebsd.org>; Thu, 16 Aug 2012 14:08:44 +0000 (UTC)
Received: from skunkworks.freebsd.org (localhost [127.0.0.1])
	by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id q7GE8ixb086680
	for <perforce@freebsd.org>; Thu, 16 Aug 2012 14:08:44 GMT
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id q7GE8iRC086677
	for perforce@freebsd.org; Thu, 16 Aug 2012 14:08:44 GMT
	(envelope-from jhb@freebsd.org)
Date: Thu, 16 Aug 2012 14:08:44 GMT
Message-Id: <201208161408.q7GE8iRC086677@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 216005 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Aug 2012 14:08:46 -0000

http://p4web.freebsd.org/@@216005?ac=10

Change 216005 by jhb@jhb_jhbbsd on 2012/08/16 14:08:24

	Don't call mfi_startio() explicitly from the callback.
	Instead, let the interrupt handler do that when this
	command completes, but go ahead and unthaw the queue as
	soon as the callback runs.  This matches what twe(4) does.

Affected files ...

.. //depot/projects/smpng/sys/dev/mfi/mfi.c#39 edit

Differences ...

==== //depot/projects/smpng/sys/dev/mfi/mfi.c#39 (text) ====

@@ -2273,10 +2273,7 @@
 	else
 		mfi_send_frame(sc, cm);
 
-	if (sc->mfi_flags & MFI_FLAGS_QFRZN) {
-		sc->mfi_flags &= ~MFI_FLAGS_QFRZN;
-		mfi_startio(sc);
-	}
+	sc->mfi_flags &= ~MFI_FLAGS_QFRZN;
 	return;
 }