Date: Thu, 09 Apr 2015 10:51:00 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@freebsd.org Subject: Re: svn commit: r383191 - head/Mk Message-ID: <55269FE4.2030208@FreeBSD.org> In-Reply-To: <20150409153856.GA31951@FreeBSD.org> References: <201504040535.t345ZJ9M028396@svn.freebsd.org> <20150408194202.GA45809@hades.panopticon> <5525A9C1.5010003@FreeBSD.org> <20150408232144.GX21982@hades.panopticon> <5525D48E.5090305@FreeBSD.org> <20150409110221.GB45809@hades.panopticon> <55269785.7030307@FreeBSD.org> <20150409153856.GA31951@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FRpKJs32VOVdW32avTS5uvBQ6Ch2nkIR2 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 4/9/2015 10:38 AM, Alexey Dokuchaev wrote: > On Thu, Apr 09, 2015 at 10:15:17AM -0500, Bryan Drewery wrote: >> *That* made sense. Frankly I think all dev warnings should be disabled= >> in that case though. Setting up ports like this may work but it is not= a >> good way to test a port before committing or submitting it. Many ports= >> and their framework files reference "CURDIR/../..". In r327743 I >> modified www/linux-seamonkey to use PORTSDIR here and I believe I brok= e >> the workflow for the maintainers testing. The ports tree really needs = to >> be tested as a whole. This is why portshaker exists, so you can bring = in >> your partial tree into a full tree. Unionfs in theory is for this too.= >=20 > Bryan, I'm on Dmitry's side here. Building some "foo" port from outsid= e > /usr/ports (or a properly checked out tree) is very handy feature, and = it > had worked for many years; and while perhaps never officially advertise= d, > silently breaking it is a huge POLA violation for power users. I would= > really appreciate if we can have this behavior back. I am in favor of fixing it. I just think all the tests should be disabled. It won't make sense to have some tests enabled and some not. It's no good if the port passes in your out-of-tree build for 1/2 the tests and then you just straight commit and find that it fails all of the other tests. >=20 > On a related noted, I'm generally getting more and more concerned that > the tree becomes primarily chroot/jail building-oriented. Example: >=20 > I'm personally heavily relying on ability to set OSVERSION to arbitrary= > value on per-port basis; it is very helpful to test the logic of some > complicated port (e.g. x11/nvidia-driver) to make sure you got all thes= e > checks right. Now since r369644 (also by you) I have to comment that > harness code from Mk/bsd.port.mk out. >=20 > I was actually surprised that I have to do it, since log message talks > only about "OSVERSION or UNAME_r is improperly set when building in a > jail/chroot", but in reality I cannot do a "make OSVERSION=3Dxxx" even = when > building locally. I'd also appreciate if you could change the code so > it works as described (i.e. for jail/chroot-environments, bulk package > builders, tinderbox/p*re, et al.), but not for /usr/ports, thank you. >=20 > ./danfe >=20 Read the commit log again for r369644. Setting one var and not the other leads to incorrect behavior in many ports. You must have them matching. It is not just about jails/chroots. --=20 Regards, Bryan Drewery --FRpKJs32VOVdW32avTS5uvBQ6Ch2nkIR2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVJp/kAAoJEDXXcbtuRpfPuxUH/R3Dqrmgzg1yFuYs3v0/tL+b TvWgQvDMCpmfjuLeRfjqHtApVK74m/2AVQOS98gFIpLRJ8oTLuodnifaDymGIMbc EUlrA7TOo2WNxFZG83c1XPSYPMMMcH/Nrb4KaV7KE63l771ZRlZfT7Zt3wfYFxyA 6j1L9N/sEC0O++ZIyamiRAJA73BHFKckQ6MvvADXtGBpNkTMYyClpNgvtooJVFCA +NrIVB2m8d0HnehjEFXx+4R7JJgH2ofa6nfFa80dOwrK0kwppdG8U7hqfvN3CX1L xB5fBJZvW1L+ItplUfHG2x4MoJUpghKt8WPzEOl+TrFKDQDWk1Fpm1D7jVO7SdA= =YU+n -----END PGP SIGNATURE----- --FRpKJs32VOVdW32avTS5uvBQ6Ch2nkIR2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55269FE4.2030208>