From owner-svn-ports-all@freebsd.org Wed Feb 3 14:30:17 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3FB91A9A5BB; Wed, 3 Feb 2016 14:30:17 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from mail.madpilot.net (grunt.madpilot.net [78.47.145.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 06ADC11DD; Wed, 3 Feb 2016 14:30:16 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from mail (mail [192.168.254.3]) by mail.madpilot.net (Postfix) with ESMTP id 3pwQQY19FhzZrb; Wed, 3 Feb 2016 15:30:13 +0100 (CET) Received: from mail.madpilot.net ([192.168.254.3]) by mail (mail.madpilot.net [192.168.254.3]) (amavisd-new, port 10024) with ESMTP id PMi9AUITKi2i; Wed, 3 Feb 2016 15:30:10 +0100 (CET) Received: from marvin.madpilot.net (micro.madpilot.net [88.149.173.206]) by mail.madpilot.net (Postfix) with ESMTPSA; Wed, 3 Feb 2016 15:30:09 +0100 (CET) Subject: Re: svn commit: r407901 - in head/net-mgmt/collectd5: . files To: Alexey Dokuchaev References: <201602022308.u12N8kud098510@repo.freebsd.org> <20160203065658.GA77151@FreeBSD.org> <56B1BFBD.7030301@FreeBSD.org> <20160203132636.GB24872@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Guido Falsi Message-ID: <56B20EF0.1080606@FreeBSD.org> Date: Wed, 3 Feb 2016 15:30:08 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160203132636.GB24872@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Feb 2016 14:30:17 -0000 On 02/03/16 14:26, Alexey Dokuchaev wrote: > On Wed, Feb 03, 2016 at 09:52:13AM +0100, Guido Falsi wrote: >> On 02/03/16 07:56, Alexey Dokuchaev wrote: >>> On Tue, Feb 02, 2016 at 11:08:46PM +0000, Guido Falsi wrote: >>>> New Revision: 407901 >>>> URL: https://svnweb.freebsd.org/changeset/ports/407901 >>>> >>>> Log: >>>> - Update to 5.5.1 >>>> - Mark MONGODB option as BROKEN >>> >>> Commit log does not explain what's exactly broken, which makes it >>> (the log) pretty useless. :( >> >> That information is in the PR, which is referenced by the commit >> message, I thought that could be enough. > > At least a few words should be made part of the commit log; bugzilla could > be down or something else. While it's OK to omit "Submitted by" because it > included in the PR, technical bits of information related to the commit are > better be part of the log. I understand, I'll be more careful in the future. In this case the option makes the port fail to build due to API changes in MongoDB. -- Guido Falsi