From owner-svn-ports-all@freebsd.org Wed Feb 10 16:31:22 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5704854BB00; Wed, 10 Feb 2021 16:31:22 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DbQHt25H6z4hlp; Wed, 10 Feb 2021 16:31:22 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1612974682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jeCECWxNbUbwMzKZZZpZ5/dSyaHzouPLEsJBHvJMLM=; b=jGkrBATp5oANXzdEegQopYxhiKHw+cpnvS6U9byE4s4tkZbSygnCDGTodDP8ZaP59K9rr6 X/dIm9v29+ttJAKUMVZ27AeqpgOYP9mUsgUC0YsqaW/xIgqeVj69iPCOrhqRoJ/KEDbpiK uG+vGh3PVhAASHRxl1W9F+3D/sRYzYiCASYIddfBp0yCQ9Ar8r8+yZmNZCq/ScXav7JMew x/jryukugmLS4PSgo4zbjWD5OzAwsTCiQmPzMc9ZZ/bTGGPUC5abLy3AAOqvCLqDetSSFr PqZmHxsdmgTgGLn5HWotw3EadPmM3gR9+3bUVrTV48OK6GruDDQNtzui38ZK1g== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 38AA7E96A; Wed, 10 Feb 2021 16:31:22 +0000 (UTC) Date: Wed, 10 Feb 2021 16:31:22 +0000 From: Alexey Dokuchaev To: Joseph Mingrone Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r564803 - in head/sysutils: . rmlint rmlint/files Message-ID: <20210210163122.GA26910@FreeBSD.org> References: <202102091926.119JQQL8050604@repo.freebsd.org> <20210210023501.GA65146@FreeBSD.org> <868s7wlyd8.fsf@phe.ftfl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <868s7wlyd8.fsf@phe.ftfl.ca> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1612974682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6jeCECWxNbUbwMzKZZZpZ5/dSyaHzouPLEsJBHvJMLM=; b=GXAlw1K/JzDQRorJ2TSnaBAOlYhOVkORJRpwBVNJ2jfkZMJh01H2muqrKvYU2sw8BOT2K2 h00pOKZAB4gLo8Nd8JCT6yteWnr/d6NNrhbzTRxJriyb2Y/hzMD1iItYqfPnUt3qu5YWan 61/h50dCEM7StN4zXoaVjRHcy+i+YGtsNQ1lKJjZ3Q4bMocW+vCQL500gTYcZ6L8j8Qcn6 tzPMtHuRYcowRfR1vw4VanXBtbyCHuISBSsel1ezsrPrwN+527sMBB/hGq5T4QDnzo0SYW DTxCWLeB+OVt6pr9YRKnt3qWtDMt6dvxmhXMLGQgOVhMtbdP7Kgj/GnT4ZY0ig== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1612974682; a=rsa-sha256; cv=none; b=BwZy2XtPlQU1depxEk0YjadT1YIaJRA1rqHr24ltrJVEJKQvUcRyF18/3DNJYQnHAmNZPW uUU81k/DsXykB0c2D94mHneSvywHXzg7LQZxaAyz/dAPL5pURIM/1qigYhw5a7uESvoz/P Icpd3TgnPRVYJt5ODLWQszg7Bgkf+bYFzviVqSFkAuYtWytbnAVfqxrXoFIsQoOroRO3yF YYk+AJ1iwpHfkZHsTvkAZEdBpk7NvuFMl579CkXAzvNqoGfjL3iz4W0dmUrLG4b6OO617x 1PPAs2JPeUU1QGcNeQDAoWyiGKBinlFSHI2E9t1NZe3gzDe8vXJ7LFtLtI8KBg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 16:31:22 -0000 On Wed, Feb 10, 2021 at 11:46:11AM -0400, Joseph Mingrone wrote: > On Wed, 2021-02-10 at 02:35, Alexey Dokuchaev wrote: > > > On Tue, Feb 09, 2021 at 07:26:26PM +0000, Joseph Mingrone wrote: > >> New Revision: 564803 > >> URL: https://svnweb.freebsd.org/changeset/ports/564803 > > >> Log: > >> New port, sysutils/rmlint: Remove duplicates from your filesystem > > > Hi Joseph, > > > I'm afraid this was not sufficiently reviewed, there are number of > > issues with this port, I'll comment on the more serious ones. > > All should be fixed in r564864. > > There was a long gap between when I first looked at this submission and > when I committed. I thought that I had reviewed it more closely, but > apparently not. When it passed build and run tests, I committed too > quickly. Understood; thank you! ./danfe