From owner-svn-src-all@freebsd.org Thu May 24 05:13:27 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA927EFDF9A; Thu, 24 May 2018 05:13:26 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 838DD74442; Thu, 24 May 2018 05:13:26 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-io0-f177.google.com (mail-io0-f177.google.com [209.85.223.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 40C1ADFD2; Thu, 24 May 2018 05:13:26 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-io0-f177.google.com with SMTP id o185-v6so814691iod.0; Wed, 23 May 2018 22:13:26 -0700 (PDT) X-Gm-Message-State: ALKqPwdqqni40GN+N6KN8/EIlJzfo6fuk5DtE+fjVoYoIxZyhSFiWSk6 4yShJ4LNpzcVAu/hPfVih+oRYIqY+I1VQ9+j61Y= X-Google-Smtp-Source: AB8JxZo2uMwTVMaJ9lXOEc73L+WO2l+GgjRjrt6LXtpokSCdhzNLCE9SzV2YWYRHq/ZQXzf0vv2FxnGKgeDAuRUV6T4= X-Received: by 2002:a6b:a712:: with SMTP id q18-v6mr5145996ioe.237.1527138805531; Wed, 23 May 2018 22:13:25 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:85ca:0:0:0:0:0 with HTTP; Wed, 23 May 2018 22:13:25 -0700 (PDT) In-Reply-To: <20180524050717.GY71675@FreeBSD.org> References: <201805190510.w4J5AqfS054367@repo.freebsd.org> <20180523222743.GU71675@FreeBSD.org> <20180523225729.GV71675@FreeBSD.org> <20180524044252.GW71675@FreeBSD.org> <20180524050717.GY71675@FreeBSD.org> From: Matthew Macy Date: Wed, 23 May 2018 22:13:25 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r333860 - head/sys/kern To: Gleb Smirnoff Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 05:13:27 -0000 On Wed, May 23, 2018 at 10:07 PM, Gleb Smirnoff wrote: > Can you please explain the bug supposed to be fixed by r333860 QUESTION MARK Did I say it fixed a bug? Or are you saying we should just turn off compiler warnings because Gleb Smirnoff knows better? -M > On Wed, May 23, 2018 at 09:51:34PM -0700, Matthew Macy wrote: > M> Warnings find bugs PERIOD. Although most are not useful, I've found > M> quite a number of real issues from compiling with gcc8. > M> > M> If you want to _actually_ be helpful fix these: > M> https://people.freebsd.org/~mmacy/gcc8logs/GENERIC-NODEBUG.log > M> > M> https://people.freebsd.org/~mmacy/gcc8logs/GENERIC.log > M> > M> On Wed, May 23, 2018 at 9:42 PM, Gleb Smirnoff wrote: > M> > Let me repeat again. The warning is a false positive, and thus assignment > M> > isn't useful. I'm not worried about a single instruction, more about > M> > polluting the code. > M> > > M> > If the warning was escalated to build error, and we did carry about > M> > building with gcc8, in this case the assignment should be added with > M> > a comment /* pacify gcc */. > M> > > M> > On Wed, May 23, 2018 at 03:59:33PM -0700, Matthew Macy wrote: > M> > M> On Wed, May 23, 2018 at 3:57 PM, Gleb Smirnoff wrote: > M> > M> > The initialization isn't useful. > M> > M> > M> > M> It silences a gcc warning. So yes it is. It's this exchange which is not useful. > M> > M> > M> > M> -M > M> > M> > M> > M> > M> > M> > On Wed, May 23, 2018 at 03:52:42PM -0700, Matthew Macy wrote: > M> > M> > M> Talk to the gcc devs. The warning is useful even if there are false positives. > M> > M> > M> > M> > M> > M> On Wed, May 23, 2018 at 3:27 PM, Gleb Smirnoff wrote: > M> > M> > M> > Hi, > M> > M> > M> > > M> > M> > M> > On Sat, May 19, 2018 at 05:10:52AM +0000, Matt Macy wrote: > M> > M> > M> > M> Author: mmacy > M> > M> > M> > M> Date: Sat May 19 05:10:51 2018 > M> > M> > M> > M> New Revision: 333860 > M> > M> > M> > M> URL: https://svnweb.freebsd.org/changeset/base/333860 > M> > M> > M> > M> > M> > M> > M> > M> Log: > M> > M> > M> > M> sendfile: annotate unused value and ensure that npages is actually initialized > M> > M> > M> > M> > M> > M> > M> > M> Modified: > M> > M> > M> > M> head/sys/kern/kern_sendfile.c > M> > M> > M> > M> > M> > M> > M> > M> Modified: head/sys/kern/kern_sendfile.c > M> > M> > M> > M> ============================================================================== > M> > M> > M> > M> --- head/sys/kern/kern_sendfile.c Sat May 19 05:09:10 2018 (r333859) > M> > M> > M> > M> +++ head/sys/kern/kern_sendfile.c Sat May 19 05:10:51 2018 (r333860) > M> > M> > M> > M> @@ -341,7 +341,7 @@ sendfile_swapin(vm_object_t obj, struct sf_io *sfio, o > M> > M> > M> > M> } > M> > M> > M> > M> > M> > M> > M> > M> for (int i = 0; i < npages;) { > M> > M> > M> > M> - int j, a, count, rv; > M> > M> > M> > M> + int j, a, count, rv __unused; > M> > M> > M> > M> > M> > M> > M> > M> /* Skip valid pages. */ > M> > M> > M> > M> if (vm_page_is_valid(pa[i], vmoff(i, off) & PAGE_MASK, > M> > M> > M> > M> @@ -688,6 +688,7 @@ retry_space: > M> > M> > M> > M> if (space == 0) { > M> > M> > M> > M> sfio = NULL; > M> > M> > M> > M> nios = 0; > M> > M> > M> > M> + npages = 0; > M> > M> > M> > M> goto prepend_header; > M> > M> > M> > M> } > M> > M> > M> > M> hdr_uio = NULL; > M> > M> > M> > > M> > M> > M> > This initialization is redundant and a compiler warning if exists is wrong. > M> > M> > M> > > M> > M> > M> > If we jump down to prepend_header with nios == 0, we won't ever use npages. > M> > M> > M> > > M> > M> > M> > -- > M> > M> > M> > Gleb Smirnoff > M> > M> > > M> > M> > -- > M> > M> > Gleb Smirnoff > M> > > M> > -- > M> > Gleb Smirnoff > > -- > Gleb Smirnoff