From owner-svn-src-head@freebsd.org Fri Mar 10 20:07:25 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9ABBCD067AF; Fri, 10 Mar 2017 20:07:25 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2BC811BA4; Fri, 10 Mar 2017 20:07:25 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-wm0-x241.google.com with SMTP id n11so712747wma.0; Fri, 10 Mar 2017 12:07:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2Zzbhf6Rupxk68kr4Xe9Vjj8tO+PwTYIw+nap6ZL4wI=; b=tjAycoocrdn3C5cgoIDs0L3/AHQK+AVyS75iunIMeGR6dKhTEgHCgDti5zTWo/uRFT KRH9ClGs3ckURV+/wJQtcxSFAfEyMh5GNC0RfSZGSWI8Kipm1oaP6vMsuib+4b4z6mKU y3v6RhLLuLdrAsek8psn7YIOocFWn2ssveb0bNtQ6asd0cjvT4QdvifUPtzS6ob8H+jV 49yNQ6ieFkY2weZi+Vzh2ZVd7mFXE8mTekA866dfyb6enOmZTheYt5Qiz5HLvCOX5UcR FJW6f4fUtETwLJ+G0RH1yWki2mEL4UrB4HYUjpgdJvGc3uYYGRrHA4rHQmTEiPM0lNuT 9M6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2Zzbhf6Rupxk68kr4Xe9Vjj8tO+PwTYIw+nap6ZL4wI=; b=t8CjYcAWyxD08CcG34EcBg4g9mb3a4TTYEPllwjJ2jRhk8EQlS+zTiSx5pqvKi2JTa A1P21KgnCqUW2HPMM7bpM50lPpeDfaTT6Dg/o6xJBhceD0EoK9OjJ8kxl8AA49wLtx22 Tq7nxgl8Hyn3IpKtI/H4iUYusWUPL6ZQYAqLOIFV7EF2Pq3n+3MOSh2DAmi/6g2MKszN fRk9+HPD2WQLQjwASeO48k5NA0nBl900TO8lztem5FdZtTbJVbwKjHK3Mz05ht08BRek Vy6yJm92NR6lzohrePe8ah8FYk3E0vByaCfUaWnTBDBg8cuzB+t1NvOSkGQxyhyLaysn zm8g== X-Gm-Message-State: AFeK/H35IPo9V/cXgcl4T6njFSReCEz9aQvHtkxSuwRb14HYInlZZtwnGXTeS//I7XMmV2fTJk3kqpQfPjHJjg== X-Received: by 10.28.173.193 with SMTP id w184mr630641wme.106.1489176442569; Fri, 10 Mar 2017 12:07:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.128.133 with HTTP; Fri, 10 Mar 2017 12:07:21 -0800 (PST) In-Reply-To: References: <201701100323.v0A3NMAI045868@repo.freebsd.org> <20170215100637.2xsyyu46odzig4c4@dhcp-3-221.uk.xensource.com> From: Adrian Chadd Date: Fri, 10 Mar 2017 12:07:21 -0800 Message-ID: Subject: Re: svn commit: r311849 - in head: . sys/amd64/conf sys/arm64/conf sys/conf sys/dev/e1000 sys/i386/conf sys/mips/conf sys/modules sys/modules/em sys/modules/igb sys/powerpc/conf To: Navdeep Parhar Cc: Ryan Stone , Warner Losh , Sean Bruno , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 20:07:25 -0000 s/ifconfig/put-it-in-a-config-file-in-share-so-we-dont-have-to-patch-ifconf= ig-every-time-we-change-this-kthxbai/g -adrian On 10 March 2017 at 11:12, Navdeep Parhar wrote: > On Fri, Mar 10, 2017 at 10:41 AM, Ryan Stone wrote: >> There's also the issue that running "ifconfig igb0 blah" during startup = will >> cause if_igb to be automatically loaded by ifconfig. >> >> I guess we could add a dummy if_igb.ko that just has a dependency on >> if_em.ko > > I do similar stuff in cxgbe (if_cxl.ko and if_cc.ko exist solely to > drag in if_cxgbe.ko as a dependency). In hindsight I wish I'd just > added a list of ifnet names -> kld map to ifconfig instead. It would > have been an ugly hack but much simpler. > > Regards, > Navdeep > >> >> On Fri, Mar 10, 2017 at 1:13 PM, Warner Losh wrote: >>> >>> On Fri, Mar 10, 2017 at 11:06 AM, Sean Bruno wrote= : >>> > >>> > >>> > On 02/15/17 03:06, Roger Pau Monn=C3=A9 wrote: >>> >> On Tue, Jan 10, 2017 at 03:23:22AM +0000, Sean Bruno wrote: >>> >>> Author: sbruno >>> >>> Date: Tue Jan 10 03:23:22 2017 >>> >>> New Revision: 311849 >>> >>> URL: https://svnweb.freebsd.org/changeset/base/311849 >>> >>> >>> >>> Log: >>> >>> Migrate e1000 to the IFLIB framework: >>> >>> - em(4) igb(4) and lem(4) >>> >>> - deprecate the igb device from kernel configurations >>> >>> - create a symbolic link in /boot/kernel from if_em.ko to if_igb.= ko >>> >> >>> >> This linking causes mfsBSD to choke when building an image from HEAD= . >>> >> It tries >>> >> to issue the following command: >>> >> >>> >> ${_v}${CP} -rp ${_BOOTDIR}/kernel ${WRKDIR}/disk/boot >>> >> >>> >> Which fails when finding the symbol link. I can send a patch to chan= ge >>> >> that to >>> >> -Rp, which would work fine, but wouldn't it be better to either >>> >> completely >>> >> remove if_igb.ko, or simply copy if_em.ko to if_igb.ko? >>> >> >>> >> I'm wondering if for example anyone strips down it's /boot/kernel/ >>> >> manually, by >>> >> removing unused modules, and what would happen if if_em.ko is remove= d >>> >> but not >>> >> if_igb.ko. >>> >> >>> >> Roger. >>> >> >>> >> >>> > >>> > Well, this was my naive attempt to make upgrades for users to be >>> > non-eventful in the event they have "if_igb_load=3DYES" in their >>> > loader.conf instead of having it built into their kernel. >>> > >>> > If the -Rp works, I'll add that instead. >>> >>> The module name is encoded in the module itself. The boot loader looks >>> it up to see which module to load. Maybe there's a way to fix it so >>> both load from one file? >>> >>> Warner >>> >> >