From owner-svn-src-projects@FreeBSD.ORG Wed Jan 16 07:19:24 2013 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 94D9D4A5; Wed, 16 Jan 2013 07:19:24 +0000 (UTC) (envelope-from lstewart@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id 83725E90; Wed, 16 Jan 2013 07:19:24 +0000 (UTC) Received: from svn.freebsd.org (svn.FreeBSD.org [8.8.178.70]) by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id r0G7JOgo027220; Wed, 16 Jan 2013 07:19:24 GMT (envelope-from lstewart@svn.freebsd.org) Received: (from lstewart@localhost) by svn.freebsd.org (8.14.5/8.14.5/Submit) id r0G7JO2T027219; Wed, 16 Jan 2013 07:19:24 GMT (envelope-from lstewart@svn.freebsd.org) Message-Id: <201301160719.r0G7JO2T027219@svn.freebsd.org> From: Lawrence Stewart Date: Wed, 16 Jan 2013 07:19:24 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r245498 - projects/diffused_head/sbin/ipfw/diffuse_collector X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2013 07:19:24 -0000 Author: lstewart Date: Wed Jan 16 07:19:23 2013 New Revision: 245498 URL: http://svnweb.freebsd.org/changeset/base/245498 Log: The template offset is not required when parsing an individual rule and was being used uninitalised which is a bug. Remove the variable. Reported by: clang Modified: projects/diffused_head/sbin/ipfw/diffuse_collector/diffuse_collector.c Modified: projects/diffused_head/sbin/ipfw/diffuse_collector/diffuse_collector.c ============================================================================== --- projects/diffused_head/sbin/ipfw/diffuse_collector/diffuse_collector.c Wed Jan 16 06:12:19 2013 (r245497) +++ projects/diffused_head/sbin/ipfw/diffuse_collector/diffuse_collector.c Wed Jan 16 07:19:23 2013 (r245498) @@ -854,7 +854,7 @@ parse_rule(struct class_node *cnode, str { struct flow_class *c; struct rule_entry *n, *prev, *r; - int dlen, i, offs, toffs, type; + int dlen, i, offs, type; offs = 0; type = -1; @@ -878,7 +878,7 @@ parse_rule(struct class_node *cnode, str switch(t->fields[i].idx) { case DIP_IE_CLASSES: - while (offs - toffs < dlen - 1) { + while (offs < dlen - 1) { c = (struct flow_class *)malloc( sizeof(struct flow_class)); if (c == NULL)