From owner-svn-src-all@FreeBSD.ORG  Thu Nov 27 11:00:31 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id F237FC9B;
 Thu, 27 Nov 2014 11:00:30 +0000 (UTC)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id AF971113;
 Thu, 27 Nov 2014 11:00:30 +0000 (UTC)
Received: from nine.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id B611BA195;
 Thu, 27 Nov 2014 11:00:28 +0000 (UTC)
Received: by nine.des.no (Postfix, from userid 1001)
 id 268B21405; Thu, 27 Nov 2014 12:00:20 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Ermal =?utf-8?Q?Lu=C3=A7i?= <eri@freebsd.org>
Subject: Re: svn commit: r274709 - head/sys/netpfil/pf
References: <201411191331.sAJDV9bH092190@svn.freebsd.org>
 <86tx1nvcy4.fsf@nine.des.no> <86ppcbvb04.fsf@nine.des.no>
 <86ioi3y0gb.fsf@nine.des.no>
 <CAPBZQG3i2h-wUQa16d0gt+fpsfNEBHgZsvtryvnwtrPVZsw8YA@mail.gmail.com>
 <861torxt7j.fsf@nine.des.no>
 <CAPBZQG3rOd43MEuSzvJfHCY=MDoTLy1VQ-2Juf-5zy7w+S24rg@mail.gmail.com>
Date: Thu, 27 Nov 2014 12:00:20 +0100
In-Reply-To: <CAPBZQG3rOd43MEuSzvJfHCY=MDoTLy1VQ-2Juf-5zy7w+S24rg@mail.gmail.com>
 ("Ermal =?utf-8?Q?Lu=C3=A7i=22's?= message of "Thu, 27 Nov 2014 08:26:40
 +0100")
Message-ID: <86sih4oqm3.fsf@nine.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2014 11:00:31 -0000

Ermal Lu=C3=A7i <eri@freebsd.org> writes:
> The existing sate of the world i think there will be checksum issues
> again especially in policy routing situations.

You mean if a packet is destined for an interface that has offloading
enabled, but pf decides to reroute it to an interface that doesn't?  I
don't know how these cases are currently handled, but the result of my
patch will still be significantly better than the situation both before
and after your commit, and your commit kills network performance.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no