From owner-cvs-all@FreeBSD.ORG Fri Apr 16 04:42:03 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 845A816A4CE; Fri, 16 Apr 2004 04:42:03 -0700 (PDT) Received: from spider.deepcore.dk (cpe.atm2-0-53484.0x50a6c9a6.abnxx9.customer.tele.dk [80.166.201.166]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FB6243D55; Fri, 16 Apr 2004 04:42:02 -0700 (PDT) (envelope-from sos@DeepCore.dk) Received: from DeepCore.dk (sos.deepcore.dk [194.192.25.130]) by spider.deepcore.dk (8.12.11/8.12.10) with ESMTP id i3GBfkRn003825; Fri, 16 Apr 2004 13:41:52 +0200 (CEST) (envelope-from sos@DeepCore.dk) Message-ID: <407FC67A.7090306@DeepCore.dk> Date: Fri, 16 Apr 2004 13:41:46 +0200 From: =?UTF-8?B?U8O4cmVuIFNjaG1pZHQ=?= User-Agent: Mozilla Thunderbird 0.5 (X11/20040329) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Roman Kurakin References: <20040413094519.7230616A4DB@hub.freebsd.org> <20040415162313.S92883@root.org> <407F9CB7.3020407@DeepCore.dk> <407FC333.6000901@cronyx.ru> In-Reply-To: <407FC333.6000901@cronyx.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-mail-scanned: by DeepCore Virus & Spam killer v1.4 cc: cvs-src@FreeBSD.ORG cc: =?UTF-8?B?77+9?= cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Nate Lawson Subject: Re: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-card.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Apr 2004 11:42:03 -0000 Roman Kurakin wrote: > Søren Schmidt wrote: > >>> Includes fixes to avoid checking the ATA_FLAG_54_58 bit, fixing LBA >>> detection: >>> Submitted by: rk >> >> >> not true, rk submitted the problem not the code. > > > Probably you are talking about me "rik" :-) > I realy doesn't submit any code. I just tell my suggestions that > checking this bit > is bad idea according to ata spec, and according last ata specs it > shouldn't be > used at all since it obsoleted. So I didn't submit any fixes about it. > Only idea. > So this may be "Asked by" or "Pointed by" :-) Right, it may break ATA on old devices though, but I guess none of these drives are in use any more. The real problem here is that I cannot just use the latest ATA specs (it would make my life *alot* simpler though :) ), I need to make things work that are compatible to at least back to ATA rev3 so just relying on things be obsoleted in the latest spec revision doesn't cut it.. > Code I submitted was to make ata driver more verbose about CHS mode. > They still are not there and should be revised to make them possible to > apply to current code. I'll think about it, but since CHS mode is almost no longer used anyways and the info can pretty easily be calculated from the LBA's printed.. > By the way, may be it would be a nice idea to warn users that they have > ATA_FLAG_54_58 bit off, and device will work in LBA mode not > in CHS as was before? Users wont notice at all, from users perspective the disk is just a bunch of sectors, the interface method used to talk to the disk is nowhere to be seen... -- -Søren