From owner-svn-src-all@FreeBSD.ORG  Fri Apr  2 15:26:41 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 98BF11065674;
	Fri,  2 Apr 2010 15:26:41 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 732268FC13;
	Fri,  2 Apr 2010 15:26:40 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA01840;
	Fri, 02 Apr 2010 18:26:38 +0300 (EEST)
	(envelope-from avg@freebsd.org)
Message-ID: <4BB60CAE.4090000@freebsd.org>
Date: Fri, 02 Apr 2010 18:26:38 +0300
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Thunderbird 2.0.0.24 (X11/20100319)
MIME-Version: 1.0
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
References: <201004021512.o32FCVUM093282@svn.freebsd.org>
In-Reply-To: <201004021512.o32FCVUM093282@svn.freebsd.org>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: svn commit: r206097 - in head/sys: geom kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2010 15:26:41 -0000

on 02/04/2010 18:12 Andriy Gapon said the following:
> Author: avg
> Date: Fri Apr  2 15:12:31 2010
> New Revision: 206097
> URL: http://svn.freebsd.org/changeset/base/206097
> 
> Log:
>   bo_bsize: revert r205860 and take an alternative approch in getblk
>   
>   In r205860 I missed the fact that there is code that strongly assumes
>   that devvp bo_bsize is equal to underlying provider's sectorsize.
>   In those places it is hard to obtain the sectorsize in an alternative
>   way if devvp bo_bsize is set to something else.
>   So, I am reverting bo_bsize assigment in g_vfs_open.
>   Instead, in getblk I use DEV_BSIZE block size for b_offset calculation
>   if vp is a disk vp as reported by vn_isdisk.  This should coinside with
>   vp being a devvp.
>   
>   Reported by:	Mykola Dzham <i@levsha.me>
>   Tested by:	Mykola Dzham <i@levsha.me>
>   Pointyhat to:	avg
>   MFC after:	2 weeks
>   X-ToDo:		convert bread(devvp) in all fs to use bo_bsize-d blocks


I should have added that the issue was a panic like the following:
panic: wrong length 512 for sectorsize 4096

Interesting part of stack trace:
...
#9  0xffffffff8020642b in panic
#10 0xffffffff801b4700 in g_io_request
#11 0xffffffff803c33ae in vnode_pager_generic_getpages
...

-- 
Andriy Gapon