From owner-svn-src-all@freebsd.org  Wed Mar 15 23:52:01 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D1B5BD0EFA2;
 Wed, 15 Mar 2017 23:52:01 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4F89C17AB;
 Wed, 15 Mar 2017 23:52:01 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v2FNpuZN082624
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Thu, 16 Mar 2017 01:51:56 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v2FNpuZN082624
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id v2FNpu0x082623;
 Thu, 16 Mar 2017 01:51:56 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Thu, 16 Mar 2017 01:51:56 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: John Baldwin <jhb@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r315323 - head/sys/kern
Message-ID: <20170315235156.GM16105@kib.kiev.ua>
References: <201703151823.v2FINWN9083379@repo.freebsd.org>
 <3167768.s4jIG6eyGp@ralph.baldwin.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3167768.s4jIG6eyGp@ralph.baldwin.cx>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Mar 2017 23:52:01 -0000

On Wed, Mar 15, 2017 at 12:21:00PM -0700, John Baldwin wrote:
> On Wednesday, March 15, 2017 06:23:32 PM John Baldwin wrote:
> > Author: jhb
> > Date: Wed Mar 15 18:23:32 2017
> > New Revision: 315323
> > URL: https://svnweb.freebsd.org/changeset/base/315323
> > 
> > Log:
> >   Use UMA_ALIGN_PTR instead of sizeof(void *) for zone alignment.
> >   
> >   uma_zcreate()'s alignment argument is supposed to be sizeof(foo) - 1,
> >   and uma.h provides a set of helper macros for common types.  Passing
> >   sizeof(void *) results in all of the members being misaligned triggering
> >   unaligned access faults on certain architectures (notably MIPS).
> >   
> >   Reported by:	brooks
> >   Obtained from:	CheriBSD
> >   MFC after:	3 days
> >   Sponsored by:	DARPA / AFRL
> > 
> > Modified:
> >   head/sys/kern/vfs_lookup.c
> 
> We should perhaps add a KASSERT() to uma_zcreate to catch this sort of
> thing.  Something like KASSERT(powerof2(align + 1)) (assuming there isn't
> a real use case for having non-power-of-2 alignments)?
> 
Will you do it ?