From owner-freebsd-net Sat Jan 20 20: 4:20 2001 Delivered-To: freebsd-net@freebsd.org Received: from homer.softweyr.com (bsdconspiracy.net [208.187.122.220]) by hub.freebsd.org (Postfix) with ESMTP id 8649237B401 for ; Sat, 20 Jan 2001 20:03:47 -0800 (PST) Received: from [127.0.0.1] (helo=softweyr.com ident=Fools trust ident!) by homer.softweyr.com with esmtp (Exim 3.16 #1) id 14KBq8-0000UJ-00; Sat, 20 Jan 2001 21:10:52 -0700 Message-ID: <3A6A614C.3004DD43@softweyr.com> Date: Sat, 20 Jan 2001 21:10:52 -0700 From: Wes Peters Organization: Softweyr LLC X-Mailer: Mozilla 4.75 [en] (X11; U; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: Dima Dorfman Cc: Ben Smithurst , Garrett Wollman , freebsd-net@FreeBSD.ORG Subject: Re: manual page review: connect(2) EAGAIN error References: <20010120234740.E74B53E02@bazooka.unixfreak.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Dima Dorfman wrote: > > > oops, looks like you already answered that (EADDRNOTAVAIL) in your last > > message. sorry. If you fix the code to return EADDRNOTAVAIL then the PR > > can be closed as it will no longer apply. > > I sent a patch to fix this in a response to this thread, but it seems > noone noticed. You can find the e-mail here: If I don't hear any objections, I'll commit this (and fix the man page). For your review simplicity, the patch is: Index: in_pcb.c =================================================================== RCS file: /st/src/FreeBSD/src/sys/netinet/in_pcb.c,v retrieving revision 1.71 diff -u -r1.71 in_pcb.c --- in_pcb.c 2000/12/27 03:02:29 1.71 +++ in_pcb.c 2001/01/20 00:31:27 @@ -313,7 +313,7 @@ * occurred above. */ inp->inp_laddr.s_addr = INADDR_ANY; - return (EAGAIN); + return (EADDRNOTAVAIL); } --*lastport; if (*lastport > first || *lastport < last) @@ -334,7 +334,7 @@ * occurred above. */ inp->inp_laddr.s_addr = INADDR_ANY; - return (EAGAIN); + return (EADDRNOTAVAIL); } ++*lastport; if (*lastport < first || *lastport > last) -- "Where am I, and what am I doing in this handbasket?" Wes Peters Softweyr LLC wes@softweyr.com http://softweyr.com/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message