From owner-cvs-all@FreeBSD.ORG  Thu Nov 17 13:16:49 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E915216A41F;
	Thu, 17 Nov 2005 13:16:49 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 65CA943D45;
	Thu, 17 Nov 2005 13:16:49 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 775F046BBA;
	Thu, 17 Nov 2005 08:16:46 -0500 (EST)
Date: Thu, 17 Nov 2005 13:16:46 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Hartmut Brandt <harti@FreeBSD.org>
In-Reply-To: <200511171219.jAHCJJw6079767@repoman.freebsd.org>
Message-ID: <20051117131533.H77687@fledge.watson.org>
References: <200511171219.jAHCJJw6079767@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/rpc.lockd kern.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Nov 2005 13:16:50 -0000


On Thu, 17 Nov 2005, Hartmut Brandt wrote:

> harti       2005-11-17 12:19:19 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    usr.sbin/rpc.lockd   kern.c
>  Log:
>  When a user is in more than 16 groups the call to authunix_create() will
>  result in abort() beeing called. This is because there is a limit of
>  the number of groups in the RPC which is 16. When the actual number of
>  groups is too large it results in xdr_array() returning an error which,
>  in turn, authunix_create() handles by just calling abort().
>
>  Fix this by passing only the first 16 groups to authunix_create().

It might be nice to add a comment to params.h by the definition of 
MAXGROUPS pointing at this and any other known gotchas.  We've had a 
number of requests to support significantly extended groups in FreeBSD, 
and I did some initial hacking on variable length group storage for 
credentials but didn't bring it to completion.  If this is something 
you're interested in looking at though, I'm happy to spread the pain :-).

Robert N M Watson