From owner-svn-src-all@freebsd.org Sat Aug 22 14:21:02 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 784533BCE62 for ; Sat, 22 Aug 2020 14:21:02 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BYgXs55yKz4h9y for ; Sat, 22 Aug 2020 14:21:01 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qk1-x743.google.com with SMTP id u3so3818477qkd.9 for ; Sat, 22 Aug 2020 07:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WZCUnj5RXcI4LfvUWRchChu0oemsDA6MzwTo2sNmht4=; b=g/hRjWQD8unG7ogJoWrDboq0whWkUkBuqQ+KlWiuTZZWfjpe+BwnURUoU7cSU/AAmb 0NRl/S0OCMq29ao2Gt/BuXw6L/2MuJfFAQgLituuQb6bUmMcOXBRp1V+QNJD1DlPYxx4 tliu+r3jb7b1TwLwkPque88JdyDy1MBZVHziHgPxbs35jG6Jrjn+TOovX8ZiWS3uw0u3 kSzmHNeADaO0TZ8PoYGvTtrF8GEc1s6bEAD8IFjRU2ZK3THlejcK9VA+aXqlknjBEgNo bWthZoVVytYXDhKF2k2r/POYHapDU/SmW2PMXEfAWQxN2WY4qk8VaNNaDpZmVueYeEw6 SapQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WZCUnj5RXcI4LfvUWRchChu0oemsDA6MzwTo2sNmht4=; b=rlBBGtdzlyYDhVLYcC2xdDDHo5cziDsKdKVOaanOumQiMW67eiVsggQENlOfdnCZT3 8Jlir0TKJwFKNG1QC0R7SKuDhDUKZB/f915Ig3Yz5pbjllTRqYKDM59/nWxl/hr+CMV2 HgV/S7ZuiYp0MCzOIHQUNAg2UAzT/L/673OIzjtBTdKmRepPLjMs+oaBVFhzm4dO1nb0 kD/AN1B8K72r7wGFNs2M/0GhZhNEyF6TTvEciJBCsvgkh+VSxdNaQNl0C2eh14/5Hnh/ YcIHjazrglvPMPYLGebwY1sOzqMuEzTa4mS4NFPHvA99TmRP2oL00DoB7KHflX9KOJlA e7Og== X-Gm-Message-State: AOAM533kwuGD5+V7ZX6d3VpHZBLUvB1PNrO09IMSIpgPan6fthUF9TOI wf3eKg83HnYhHxY0+8o9B6poNA== X-Google-Smtp-Source: ABdhPJxiWG4TX6TSN8wmzCRb7knn4XeFcD7iVwNPm8A8E7goTTK+mroU40Y/bmeK+S6NEwUQJE68vA== X-Received: by 2002:a05:620a:1089:: with SMTP id g9mr6987882qkk.252.1598106060815; Sat, 22 Aug 2020 07:21:00 -0700 (PDT) Received: from mutt-hbsd (pool-100-16-231-224.bltmmd.fios.verizon.net. [100.16.231.224]) by smtp.gmail.com with ESMTPSA id i7sm5613788qtb.27.2020.08.22.07.20.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Aug 2020 07:20:59 -0700 (PDT) Date: Sat, 22 Aug 2020 10:20:59 -0400 From: Shawn Webb To: Dimitry Andric Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364482 - head/lib/libc++ Message-ID: <20200822142059.3pssuzpejjpi3mmk@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA References: <202008221205.07MC5Bb9007914@repo.freebsd.org> <20200822140711.62khzgdj5slb2yuq@mutt-hbsd> <741677B8-D4AD-418B-9D60-436AA7E34E4C@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="giuqngjgxjknnwgr" Content-Disposition: inline In-Reply-To: <741677B8-D4AD-418B-9D60-436AA7E34E4C@FreeBSD.org> X-Rspamd-Queue-Id: 4BYgXs55yKz4h9y X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=g/hRjWQD; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::743 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org X-Spamd-Result: default: False [-3.32 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[hardenedbsd.org]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; NEURAL_HAM_SHORT(-1.22)[-1.224]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::743:from]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MID_RHS_NOT_FQDN(0.50)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all]; RECEIVED_SPAMHAUS_PBL(0.00)[100.16.231.224:received] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Aug 2020 14:21:02 -0000 --giuqngjgxjknnwgr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 22, 2020 at 04:17:33PM +0200, Dimitry Andric wrote: > On 22 Aug 2020, at 16:07, Shawn Webb wrote: > >=20 > > On Sat, Aug 22, 2020 at 12:05:11PM +0000, Dimitry Andric wrote: > >> Author: dim > >> Date: Sat Aug 22 12:05:11 2020 > >> New Revision: 364482 > >> URL: https://svnweb.freebsd.org/changeset/base/364482 > >>=20 > >> Log: > >> Add a few new source files to libc++, in particular the implementation > >> part of std::random_shuffle. These were split off at some point by > >> upstream, but I forgot to add them to our Makefile. > >>=20 > >> This should allow some ports which use std::random_shuffle to correct= ly > >> link again. > >>=20 > >> Reported by: thierry > >> PR: 248795 > >> MFC after: 6 weeks > >> X-MFX-With: r364284 > >>=20 > >> Modified: > >> head/lib/libc++/Makefile > >>=20 > >> Modified: head/lib/libc++/Makefile > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/lib/libc++/Makefile Sat Aug 22 11:59:14 2020 (r364481) > >> +++ head/lib/libc++/Makefile Sat Aug 22 12:05:11 2020 (r364482) > >> @@ -16,6 +16,8 @@ SHLIB_LDSCRIPT=3D libc++.ldscript > >>=20 > >> SRCS+=3D algorithm.cpp > >> SRCS+=3D any.cpp > >> +SRCS+=3D atomic.cpp > >> +SRCS+=3D barrier.cpp > >> SRCS+=3D bind.cpp > >> SRCS+=3D charconv.cpp > >> SRCS+=3D chrono.cpp > >> @@ -38,6 +40,7 @@ SRCS+=3D mutex_destructor.cpp > >> SRCS+=3D new.cpp > >> SRCS+=3D optional.cpp > >> SRCS+=3D random.cpp > >> +SRCS+=3D random_shuffle.cpp > >> SRCS+=3D regex.cpp > >> SRCS+=3D shared_mutex.cpp > >> SRCS+=3D stdexcept.cpp > >=20 > > There's also these files: > >=20 > > https://github.com/HardenedBSD/hardenedBSD/commit/9410e679cc7888311f6ef= af251f8d9a311c5b19d >=20 > We intentionally don't build a number of the lldb plugins, so these > should not be needed. Did you get build failures otherwise? We did, likely because we use more llvm tools than our upstream FreeBSD. We set WITH_CLANG_EXTRAS by default. We also use CFI and SafeStack. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Sha= wn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --giuqngjgxjknnwgr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl9BKcgACgkQ/y5nonf4 4fosZg/8CKfllc2PX5MH6cHRtXhcDEFgyCZyPxCZsUuuYVtZ7dm7phwsSelWOKhv DCx5nZCuyk1SaB8EfHV4BCSJDRKfSkt1Ju4jvMJ0KVla1Ok7Um6+59svFmtzUxR6 0vrqEXT1aMwcldwWuyOotShaPFJp91BPOpJJ+XJb7VLItQA+al9SGWkkL8bBPhM4 nNQsv+54XGznHoSsTgsuAFigRS8i4ZkQDtEUfVDSpeS6tnA7H5avWtdw5vuFQViu tvEboFEkOWczm2l3t5Y731YRq0qygtIrbnhDTSQz4skVwAnJBQxJje5OZ/MUCNLr YiIkwHDhypA/tfL/rGPXtGKIhOgdEclye2YuQ6+YfLjI32zg9GZNMLgiwRCIxFDK Vquh7aiyDPFC1TDmXgDo3z8xJLa0o/vMDgQBCKoc4zROK5h1GcBEEUFnjKgXMx7f afB5ewN0H2lzsi4nWfbJQSdT1QeIDUPQu/yvv6JoUQEYBf4qe43f5wDQrOmQWrKW BU2NcqrmH8KediIMOqi/vuLXh72n/uEs6/xWqfT/VSviS7THNAuKRIFainsr5703 wVuTAmfOt1h/fEKnsPK4ZToogfc2MuqVJaNYaCxvVXbqiPHM0SsYs2JI/+AJnEFs 8+CF6vtqqP+06xiL++oq7NOCz6R+JJOlEEce26FTFM8Cr9OGdmw= =H/m9 -----END PGP SIGNATURE----- --giuqngjgxjknnwgr--