Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Aug 2020 10:20:59 -0400
From:      Shawn Webb <shawn.webb@hardenedbsd.org>
To:        Dimitry Andric <dim@FreeBSD.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r364482 - head/lib/libc++
Message-ID:  <20200822142059.3pssuzpejjpi3mmk@mutt-hbsd>
In-Reply-To: <741677B8-D4AD-418B-9D60-436AA7E34E4C@FreeBSD.org>
References:  <202008221205.07MC5Bb9007914@repo.freebsd.org> <20200822140711.62khzgdj5slb2yuq@mutt-hbsd> <741677B8-D4AD-418B-9D60-436AA7E34E4C@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--giuqngjgxjknnwgr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Aug 22, 2020 at 04:17:33PM +0200, Dimitry Andric wrote:
> On 22 Aug 2020, at 16:07, Shawn Webb <shawn.webb@hardenedbsd.org> wrote:
> >=20
> > On Sat, Aug 22, 2020 at 12:05:11PM +0000, Dimitry Andric wrote:
> >> Author: dim
> >> Date: Sat Aug 22 12:05:11 2020
> >> New Revision: 364482
> >> URL: https://svnweb.freebsd.org/changeset/base/364482
> >>=20
> >> Log:
> >>  Add a few new source files to libc++, in particular the implementation
> >>  part of std::random_shuffle. These were split off at some point by
> >>  upstream, but I forgot to add them to our Makefile.
> >>=20
> >>  This should allow some ports which use std::random_shuffle to correct=
ly
> >>  link again.
> >>=20
> >>  Reported by:	thierry
> >>  PR:		248795
> >>  MFC after:	6 weeks
> >>  X-MFX-With:	r364284
> >>=20
> >> Modified:
> >>  head/lib/libc++/Makefile
> >>=20
> >> Modified: head/lib/libc++/Makefile
> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> >> --- head/lib/libc++/Makefile	Sat Aug 22 11:59:14 2020	(r364481)
> >> +++ head/lib/libc++/Makefile	Sat Aug 22 12:05:11 2020	(r364482)
> >> @@ -16,6 +16,8 @@ SHLIB_LDSCRIPT=3D	libc++.ldscript
> >>=20
> >> SRCS+=3D		algorithm.cpp
> >> SRCS+=3D		any.cpp
> >> +SRCS+=3D		atomic.cpp
> >> +SRCS+=3D		barrier.cpp
> >> SRCS+=3D		bind.cpp
> >> SRCS+=3D		charconv.cpp
> >> SRCS+=3D		chrono.cpp
> >> @@ -38,6 +40,7 @@ SRCS+=3D		mutex_destructor.cpp
> >> SRCS+=3D		new.cpp
> >> SRCS+=3D		optional.cpp
> >> SRCS+=3D		random.cpp
> >> +SRCS+=3D		random_shuffle.cpp
> >> SRCS+=3D		regex.cpp
> >> SRCS+=3D		shared_mutex.cpp
> >> SRCS+=3D		stdexcept.cpp
> >=20
> > There's also these files:
> >=20
> > https://github.com/HardenedBSD/hardenedBSD/commit/9410e679cc7888311f6ef=
af251f8d9a311c5b19d
>=20
> We intentionally don't build a number of the lldb plugins, so these
> should not be needed. Did you get build failures otherwise?

We did, likely because we use more llvm tools than our upstream
FreeBSD. We set WITH_CLANG_EXTRAS by default. We also use CFI and
SafeStack.

Thanks,

--=20
Shawn Webb
Cofounder / Security Engineer
HardenedBSD

GPG Key ID:          0xFF2E67A277F8E1FA
GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9  3633 C85B 0AF8 AB23 0FB2
https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Sha=
wn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc

--giuqngjgxjknnwgr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl9BKcgACgkQ/y5nonf4
4fosZg/8CKfllc2PX5MH6cHRtXhcDEFgyCZyPxCZsUuuYVtZ7dm7phwsSelWOKhv
DCx5nZCuyk1SaB8EfHV4BCSJDRKfSkt1Ju4jvMJ0KVla1Ok7Um6+59svFmtzUxR6
0vrqEXT1aMwcldwWuyOotShaPFJp91BPOpJJ+XJb7VLItQA+al9SGWkkL8bBPhM4
nNQsv+54XGznHoSsTgsuAFigRS8i4ZkQDtEUfVDSpeS6tnA7H5avWtdw5vuFQViu
tvEboFEkOWczm2l3t5Y731YRq0qygtIrbnhDTSQz4skVwAnJBQxJje5OZ/MUCNLr
YiIkwHDhypA/tfL/rGPXtGKIhOgdEclye2YuQ6+YfLjI32zg9GZNMLgiwRCIxFDK
Vquh7aiyDPFC1TDmXgDo3z8xJLa0o/vMDgQBCKoc4zROK5h1GcBEEUFnjKgXMx7f
afB5ewN0H2lzsi4nWfbJQSdT1QeIDUPQu/yvv6JoUQEYBf4qe43f5wDQrOmQWrKW
BU2NcqrmH8KediIMOqi/vuLXh72n/uEs6/xWqfT/VSviS7THNAuKRIFainsr5703
wVuTAmfOt1h/fEKnsPK4ZToogfc2MuqVJaNYaCxvVXbqiPHM0SsYs2JI/+AJnEFs
8+CF6vtqqP+06xiL++oq7NOCz6R+JJOlEEce26FTFM8Cr9OGdmw=
=H/m9
-----END PGP SIGNATURE-----

--giuqngjgxjknnwgr--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200822142059.3pssuzpejjpi3mmk>