From owner-cvs-src  Mon Feb 10  1:55:28 2003
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 40B1637B401; Mon, 10 Feb 2003 01:55:25 -0800 (PST)
Received: from relay1.cris.net (relay1.cris.net [212.110.128.64])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1BC4843F93; Mon, 10 Feb 2003 01:55:20 -0800 (PST)
	(envelope-from phantom@phantom.cris.net)
Received: from phantom.cris.net (root@phantom.cris.net [212.110.130.74])
	by relay1.cris.net (8.12.6/8.12.6) with ESMTP id h1AC0Vvb046500;
	Mon, 10 Feb 2003 12:00:32 GMT
Received: (from phantom@localhost)
	by phantom.cris.net (8.12.6/8.12.2) id h1AA1mEK025837;
	Mon, 10 Feb 2003 12:01:48 +0200 (EET)
	(envelope-from phantom)
Date: Mon, 10 Feb 2003 12:01:47 +0200
From: Alexey Zelkin <phantom@FreeBSD.org.ua>
To: Alfred Perlstein <alfred@FreeBSD.org>
Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org, legacy-committers@FreeBSD.org
Subject: Re: cvs commit: src/include pthread.h src/lib/libc_r/uthread uthread_attr_getstack.c uthread_attr_setstack.c src/lib/libpthread/thread thr_attr_getstack.c thr_attr_setstack.c src/lib/libc_r/man pthread_attr.3
Message-ID: <20030210120147.A25796@phantom.cris.net>
References: <200302100848.h1A8m4Fj054987@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200302100848.h1A8m4Fj054987@repoman.freebsd.org>; from alfred@FreeBSD.org on Mon, Feb 10, 2003 at 12:48:04AM -0800
X-Operating-System: FreeBSD 4.7-STABLE i386
Sender: owner-cvs-src@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-src.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-src>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-src>
X-Loop: FreeBSD.ORG

hi,

Who reviewed this change ?  Did you told to Dan before doing it ?

And last, that purpose of this functionality ?  (I have seen a diff,
but it's interesting how these functions are supposed to be used?)

PS: We have pthread_attr_get_np() which provide functionality similar
to pthread_attr_getstack() in cleaner and correct way.  Having of
pthread_attr_setstack() is absolutely crazy idea (IMHO) because using it
after pthread_create() may (or will) crash application.

On Mon, Feb 10, 2003 at 12:48:04AM -0800, Alfred Perlstein wrote:
> alfred      2003/02/10 00:48:04 PST
> 
>   Modified files:
>     include              pthread.h 
>     lib/libc_r/man       pthread_attr.3 
>   Added files:
>     lib/libc_r/uthread   uthread_attr_getstack.c 
>                          uthread_attr_setstack.c 
>     lib/libpthread/thread thr_attr_getstack.c thr_attr_setstack.c 
>   Log:
>   Add pthread_attr_getstack() and pthread_attr_setstack().
>   
>   Submitted by: Craig Rodrigues <rodrigc@attbi.com>
>   
>   Revision  Changes    Path
>   1.27      +4 -0      src/include/pthread.h
>   1.12      +8 -0      src/lib/libc_r/man/pthread_attr.3
>   1.1       +59 -0     src/lib/libc_r/uthread/uthread_attr_getstack.c (new)
>   1.1       +58 -0     src/lib/libc_r/uthread/uthread_attr_setstack.c (new)
>   1.1       +59 -0     src/lib/libpthread/thread/thr_attr_getstack.c (new)
>   1.1       +58 -0     src/lib/libpthread/thread/thr_attr_setstack.c (new)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message