From owner-freebsd-net@FreeBSD.ORG  Tue Sep  8 16:15:31 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 34FBA1065694
	for <freebsd-net@freebsd.org>; Tue,  8 Sep 2009 16:15:31 +0000 (UTC)
	(envelope-from stef-list@memberwebs.com)
Received: from mail.npubs.com (mail.npubs.com [74.82.45.72])
	by mx1.freebsd.org (Postfix) with ESMTP id 259848FC1B
	for <freebsd-net@freebsd.org>; Tue,  8 Sep 2009 16:15:31 +0000 (UTC)
Resent-Message-Id: <none>
From: Stef Walter <stef-list@memberwebs.com>
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
MIME-Version: 1.0
To: Shteryana Shopova <shteryana@gmail.com>
References: <4AA65663.8050106@incunabulum.net> <4AA65861.8@incunabulum.net>
	<61b573980909080654x50670168x39001267ad81c6a3@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV using ClamSMTP
Resent-Date: Tue,  8 Sep 2009 16:15:31 +0000 (UTC)
Resent-From: stef-list@memberwebs.com
Cc: "freebsd-net@FreeBSD.org" <freebsd-net@freebsd.org>,
	Bruce Simpson <bms@incunabulum.net>
Subject: Re: Panic in imo_match_source (netinet/in_mcast.c)
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: stef@memberwebs.com
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
Date: Tue, 08 Sep 2009 16:15:31 -0000
X-List-Received-Date: Tue, 08 Sep 2009 16:15:31 -0000

Shteryana Shopova wrote:
> I actually managed to get the same kernel dump using the following
> sample code - http://people.freebsd.org/~syrinx/mcast/mcast_crash.c
> and the crash is 100% reproducable. A temporary fix is here -
> http://people.freebsd.org/~syrinx/mcast/in_mcast.c-20090908-01.diff
> but I actually prefer that we go over the logic in inp_join_group()
> again before proposing a patch for head as this is the second assert
> panic I am seeing it causes in the last few days. I can try making up
> a proper fix if Bruce is busy, but it will take a day or two until I'm
> able to fully test it.

Hmmmm, EADDRINUSE ... This sounds very familiar. Here's an old quagga
bug that I don't think got patched properly. It does an unexpected
double IP_ADD_MEMBERSHIP:

http://bugzilla.quagga.net/show_bug.cgi?id=212

I'll test the patch here. Thanks!

Cheers,

Stef