From owner-freebsd-hackers@FreeBSD.ORG Thu Sep 18 13:16:45 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EBA68106567A for ; Thu, 18 Sep 2008 13:16:45 +0000 (UTC) (envelope-from bounces@nabble.com) Received: from kuber.nabble.com (kuber.nabble.com [216.139.236.158]) by mx1.freebsd.org (Postfix) with ESMTP id C165A8FC0A for ; Thu, 18 Sep 2008 13:16:45 +0000 (UTC) (envelope-from bounces@nabble.com) Received: from isper.nabble.com ([192.168.236.156]) by kuber.nabble.com with esmtp (Exim 4.63) (envelope-from ) id 1KgJNE-0004XK-KD for freebsd-hackers@freebsd.org; Thu, 18 Sep 2008 06:16:44 -0700 Message-ID: <19552647.post@talk.nabble.com> Date: Thu, 18 Sep 2008 06:16:44 -0700 (PDT) From: christom To: freebsd-hackers@freebsd.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Nabble-From: christom_12@yahoo.com References: X-Mailman-Approved-At: Thu, 18 Sep 2008 13:20:48 +0000 Subject: Re: kern/127446: [patch] fix race in sys/dev/kbdmux/kbdmux.c X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2008 13:16:46 -0000 hello man, i only need a good hacker that can hack for uk bank log in for me i need that if you can do that for me i will be very grateful....cos have been try to to train to do this work i did not true with it.... Maksim Yevmenkin-2 wrote: > > On 9/17/08, Eygene Ryabinkin wrote: >> Maxim, good day. >> >> Cc'ing this discuission to hackers@ -- I was just going to write >> the separate letter on this topic to the list. >> >> Wed, Sep 17, 2008 at 09:56:14AM -0700, Maksim Yevmenkin wrote: >> > have you tried to simply set KBDMUX_LOCK/UNLOCK() to >> > mtx_lock/unlock(&Giant) ? >> >> Since kbdmux callout is initialized as non-MPSAFE, this will result in >> double locking the Giant (at least I see it from the code). I am not >> sure that this is very good -- had not yet verified that Giant is >> recursive. > > yes, giant is recursive. i think it should be fine for now (and yes, i > agree, its not very clean) > >> Can try it tomorrow. > > thanks > >> Since you had written the code and #if 0'ed the locking part, may I ask, >> why? Are there any known issues or it was just not very good to >> introduce locking at that time (rev. 1.1, 3 years ago)? > > because i did not want to touch every single keyboard driver, keyboard > subsystem and syscons :) back then. since kbdmux is pretty much > keyboard driver it was easier to leave it under giant locking. > > thanks, > max > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" > > -- View this message in context: http://www.nabble.com/Re%3A-kern-127446%3A--patch--fix-race-in-sys-dev-kbdmux-kbdmux.c-tp19539858p19552647.html Sent from the freebsd-hackers mailing list archive at Nabble.com.