From nobody Fri Jan 24 20:27:46 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YfqBB3DN8z5lsRd; Fri, 24 Jan 2025 20:27:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YfqBB1GCdz3btP; Fri, 24 Jan 2025 20:27:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737750466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LQo1Lp29qZU+vlmzvAUYnrAyCkCtbBtf9+wlu64y6DI=; b=SV+NyFpmnk4/j8ZId6zAH0OCS0jeQGoX42VhITFO42AiSYdwTmwLtSiNY+dfcMkyH7rt/0 /Q5+Hh75re7eYI0J1jqw9wlek3QaBkEjIMx2G1U017XtWJ2/gRZ0ncjpdPn3aKbXs0gp7e RwagPhG0LdmWch2veUC6ttwVMqUz2LDfXYTEKhXziZ8Xo1GtnnLUYi6o1a+OE++X6Rl+eq 7ZUT58/sOQ+IZPpv70UN8RuXf9+KTzsFc9pBCNXnbIbVFOt3naPk1/ehHmFEAxXZZrFEZL /BMynCK1t+0CkF+EeON2tFcoOsr8zm/TtEwDUSLDJhfSk3Wgq0HWsKXLLWe9mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737750466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LQo1Lp29qZU+vlmzvAUYnrAyCkCtbBtf9+wlu64y6DI=; b=VQRSO24yL88x7Ig4he+rD7i/mHGtB1Gvz7Uj+qzl+YRsPkyU2QvD9I+ybmtTrSb5QHffxl YvGrEm0qwszlbvzfpQy8iC1BmFhZWy3sPSi2vu04HDrmCLbMRj6JYpEsu3k9Afzqaj8TJz sDZV+w1b6mrQD1EcoKAQhkkfxbqYbHkbKI1QesdqI1Ukb1jO33KsPDsdXZ/t5/noWSOfqz aYAB/zzjj7wLR+0yydqtK92Iq7rQBWw5vWqcH6dk9poPwGu/Dpgb6Z/Vq81aulsHeBi1mU N94++LiaLCq0JeElymLAj1K8+JpRVGKCrQ1U2utHUlH1BO1WzcRLfSW7CoIFvw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737750466; a=rsa-sha256; cv=none; b=v/fRF/KYVBzOUaXtquLJHo64m2Zv3wHEvxffNFFOaS66i7ilzwJcv9MTJNvP3Pk8luFngx yU6we6CmSFUcgjiGreU8S1KakvqCMfek8ccI7LEF7IYsNsQIHtlJwN1sH8veH5AG2U9q6l dGd+1S/YBS5XSM3DtxdRpzkz8j0eyDwuOvEv/QjUmPa5RErJxGekAeQH/qxu45BR3hn4qe 8rYTTSLZ3F0lUhf+RNjcqmtQ5WawAMsKqZN1BQicK0IMJ+o8dd9oN+ro1JUfAIckbYhCiO KcrxtjZXTNh15fbsIIhAfAdzwkzWZgI4a4w6Pvl40oIMTPaRSKvX1/TPwjhntA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YfqBB0q8QzgYF; Fri, 24 Jan 2025 20:27:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 50OKRkFr064663; Fri, 24 Jan 2025 20:27:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 50OKRkOa064660; Fri, 24 Jan 2025 20:27:46 GMT (envelope-from git) Date: Fri, 24 Jan 2025 20:27:46 GMT Message-Id: <202501242027.50OKRkOa064660@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: ca363716fc49 - main - checkstyle9.pl: Remove unneeded checks List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ca363716fc492146978c8650b97862f94daab6bf Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=ca363716fc492146978c8650b97862f94daab6bf commit ca363716fc492146978c8650b97862f94daab6bf Author: Ahmad Khalifa AuthorDate: 2025-01-06 01:52:06 +0000 Commit: Ed Maste CommitDate: 2025-01-24 20:27:20 +0000 checkstyle9.pl: Remove unneeded checks Both the bad email check and the signoff check are handled in the "checklist" github workflow now. Reviewed by: emaste, imp Pull request: https://github.com/freebsd/freebsd-src/pull/1570 Signed-off-by: Ahmad Khalifa --- tools/build/checkstyle9.pl | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/tools/build/checkstyle9.pl b/tools/build/checkstyle9.pl index 5854cf613e01..b40c9810bc93 100755 --- a/tools/build/checkstyle9.pl +++ b/tools/build/checkstyle9.pl @@ -1253,8 +1253,6 @@ sub process { my $in_header_lines = $file ? 0 : 1; my $in_commit_log = 0; #Scanning lines before patch - my $has_sob = 0; - my $author_is_committer = 0; my $non_utf8_charset = 0; our @report = (); @@ -1450,33 +1448,6 @@ sub process { $is_patch = 1; } -# Filter out bad email addresses. - if ($line =~ /^(Author|From): .*noreply.*/) { - ERROR("Real email adress is needed\n" . $herecurr); - } - - if ($line =~ /^Author: .*[a-z-0-9]\@freebsd\.org/i) { - $author_is_committer = 1 - } - -#check the patch for a signoff: - if ($line =~ /^\s*signed-off-by:/i) { - # This is a signoff, if ugly, so do not double report. - $in_commit_log = 0; - $has_sob = 1; - - if (!($line =~ /^\s*Signed-off-by:/)) { - ERROR("The correct form is \"Signed-off-by\"\n" . - $herecurr); - $has_sob = 0; - } - if ($line =~ /^\s*signed-off-by:\S/i) { - ERROR("space required after Signed-off-by:\n" . - $herecurr); - $has_sob = 0; - } - } - # Check for wrappage within a valid hunk of the file if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { ERROR("patch seems to be corrupt (line wrapped?)\n" . @@ -2659,10 +2630,6 @@ sub process { } - if ($has_sob == 0 && $author_is_committer == 0) { - WARN("Missing Signed-off-by: line"); - } - # If we have no input at all, then there is nothing to report on # so just keep quiet. if ($#rawlines == -1) {