From owner-freebsd-fs@FreeBSD.ORG Sun Nov 27 11:37:17 2011 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C42C106567B for ; Sun, 27 Nov 2011 11:37:17 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 1FD688FC24 for ; Sun, 27 Nov 2011 11:37:16 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id 3D6427E7; Sun, 27 Nov 2011 12:00:23 +0100 (CET) Date: Sun, 27 Nov 2011 11:59:13 +0100 From: Pawel Jakub Dawidek To: Rick Macklem Message-ID: <20111127105913.GH8794@garage.freebsd.pl> References: <20111126165823.GD8794@garage.freebsd.pl> <1798569802.431412.1322359425997.JavaMail.root@erie.cs.uoguelph.ca> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dx9iWuMxHO1cCoFc" Content-Disposition: inline In-Reply-To: <1798569802.431412.1322359425997.JavaMail.root@erie.cs.uoguelph.ca> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-fs@FreeBSD.org Subject: Re: NFS corruption in recent HEAD. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Nov 2011 11:37:17 -0000 --Dx9iWuMxHO1cCoFc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 26, 2011 at 09:03:46PM -0500, Rick Macklem wrote: > Pawel Jakub Dawidek wrote: > > Hi. > >=20 > > I'm booting machine over the network using new NFS client and I'm > > getting those warnings on boot: > >=20 > > /etc/rc.subr: 666: Syntax error: "(" unexpected (expecting ";;") [...] > Oh, and maybe you could try reverting r227543 in the client (assuming > the client is post-r227543). Maybe that file's vnode type isn't set to > VREG early in the diskless booting and needs the ncl_flush() for some > reason. >=20 > I don't actually have a bug that needs r227543 to fix it. It just seemed > incorrect to flush non-VREG files (particularily VDIR). As such, reverting > it wouldn't be a big deal. I haven't tried reverting anything yet, but I think I was able to reproduce this with old NFS client as well. The problem goes away when I comment out root mount point from /etc/fstab or remove mntudp from mount options. NFS root is mounted using TCP, AFAIK and it probably happens when startup scripts (rc.d/mountcritremote) remounts root with mntudp flag. The rc.subr warning starts to appear just after mountcritremote is called. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --Dx9iWuMxHO1cCoFc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk7SGAEACgkQForvXbEpPzR0jgCfSk7qlWbtlihOUj/0Cw2osf0T baMAoL+2PaO1uOzI02VySRccGJuqw0/Q =eelX -----END PGP SIGNATURE----- --Dx9iWuMxHO1cCoFc--