From nobody Mon May 6 11:17:18 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VXzRV46HXz5K0SW; Mon, 06 May 2024 11:18:14 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Received: from mailgate.Leidinger.net (mailgate.leidinger.net [IPv6:2a00:1828:2000:313::1:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mailgate.leidinger.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VXzRV1c1Lz42Xh; Mon, 6 May 2024 11:18:14 +0000 (UTC) (envelope-from Alexander@Leidinger.net) Authentication-Results: mx1.freebsd.org; none List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leidinger.net; s=outgoing-alex; t=1714994286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kAhkb1GGAqLU8gU1mjtqJc18wECd3RWOPG9CIk2erVk=; b=kT/BFzkQuAF6Rr8SWQ08uyYb1g9cqwkgT5uSy31M7hsLv+d//U1l1D9IzH1S3o/7v143Z9 Iq/Zav4x+QviVfBrJeVips6wq21hJOWDXjLY12Wd7Lt+rF2Fz9uXyWJu9XVBwSW9tAmvaU wZyTAayV3vKcwk1Cboqn7cRkfce1mNcWF/wxqnr4UQM5U9CA53dBnAIYtRHiZMYkzxhEGe +ospZa6GmBpoXmMDTpL9gUYh9mEwW6dUCulJLYMWI4zE9zOqiB0Buii1E2i3qUT+AsArZ8 A40o8V97PzXs4+ZwrNR7ORKBJiK2/gDDZIjQbRp5CP3zfQ0/iZMx/oZkvDbOzQ== Date: Mon, 06 May 2024 13:17:18 +0200 From: Alexander Leidinger To: garyj@gmx.de Cc: Randall Stewart , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: fce03f85c5bf - main - TCP can be subject to Sack Attacks lets fix this issue. In-Reply-To: <20240506131136.1bcf87f9@ernst.home> References: <202405051310.445DAMEO069675@gitrepo.freebsd.org> <97c2eddd682d7347b0d26c0f042401bb@Leidinger.net> <20240506131136.1bcf87f9@ernst.home> Message-ID: Organization: No organization, this is a private message. Content-Type: multipart/signed; protocol="application/pgp-signature"; boundary="=_0476f1244a2466ac6fb366167ea4aae4"; micalg=pgp-sha256 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:34240, ipnet:2a00:1828::/32, country:DE] X-Rspamd-Queue-Id: 4VXzRV1c1Lz42Xh This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --=_0476f1244a2466ac6fb366167ea4aae4 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Am 2024-05-06 13:11, schrieb Gary Jennejohn: > On Mon, 06 May 2024 09:27:31 +0200 > Alexander Leidinger wrote: > >> Am 2024-05-05 15:10, schrieb Randall Stewart: >> > diff --git a/sys/netinet/tcp_stacks/sack_filter.c >> > b/sys/netinet/tcp_stacks/sack_filter.c >> > index e82fcee2ffac..fc9ee8454a1e 100644 >> > --- a/sys/netinet/tcp_stacks/sack_filter.c >> > +++ b/sys/netinet/tcp_stacks/sack_filter.c >> >> > #ifndef _KERNEL >> > + >> > +static u_int tcp_fixed_maxseg(const struct tcpcb *tp) >> > +{ >> > + /* Lets pretend their are timestamps on for user space */ >> > + return (tp->t_maxseg - 12); >> > +} >> >> Typo in the comment? >> > > Yes. Should be Let's as a contraction of Let us. As a non-native english speaker I also would change "their" in this place and reword "timestamps on for user space". Bye, Alexander. -- http://www.Leidinger.net Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_0476f1244a2466ac6fb366167ea4aae4 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc; size=833 Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEER9UlYXp1PSd08nWXEg2wmwP42IYFAmY4vEwACgkQEg2wmwP4 2IYUXw/+Is7SB2fr+ewIsH6MyUSlH2YboWlwXmbJn5yC4npO492x3JJFy1COUXOI 6fbMviyQYHy+FgMhTjfuT2kQwoJI796342K1hnHTHKUqYDFVypko6zZbcBcw2cKX kMSgHcBeinge/FMR69pQQ0jLEQqMhSXfh4Zyod7Dh7spUOjQdROo3lD4cCqVwTZV qc+hodkSkCFZqSdzb7MmNDPZVPKNPQkwhibp68/5U1rwYTfiyY7XD53QOVFPlKsy a89rKur8+aZw55z8UjpnNT8KWQSwsnHxgXmQJ/Ev3g546WmnXc7lNTni+MWg/1qk yT1dwRF6VZGqENbgDPQ1Qgzq3AYzkHnpj3AXUQK51JicH785hUTx9eTo7O7xfONZ 3+XcrZlqWjHIvK9RX4NTcbSY48bY6TwC85lBJAJFbU3NxUQZ4J0xVx8iAkn8XNuG KTZDKq3d/6gCUSOl/dZCwo4S7FIz7BEWHdCv+blZewA9x74MFofOWWlWJubcZfnb JnRWG2sVo7X5WAt5xtqNi18b/uhScXSeb+yQL1GUw8kwqhYTvuxHOsb5D6+2oQdI N9pwz+EKYCIgHBGQ02V3wOSYJB6TE5RXdZM9JfUwxukqYp2IJmdWwIyyI5T7aF2T 3Bwf5Vaunkf2jVFZOrYl8ueEz5pYX7VejsAQ7sbwa6W7A9Qvrrg= =fylh -----END PGP SIGNATURE----- --=_0476f1244a2466ac6fb366167ea4aae4--