From owner-cvs-src@FreeBSD.ORG  Tue Jan  6 12:31:08 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 22A8D16A4CE; Tue,  6 Jan 2004 12:31:08 -0800 (PST)
Received: from gw.celabo.org (gw.celabo.org [208.42.49.153])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id EFA1943D2D; Tue,  6 Jan 2004 12:31:06 -0800 (PST)
	(envelope-from nectar@celabo.org)
Received: from madman.celabo.org (madman.celabo.org [10.0.1.111])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "madman.celabo.org", Issuer "celabo.org CA" (verified OK))
	by gw.celabo.org (Postfix) with ESMTP
	id 9511C54883; Tue,  6 Jan 2004 14:31:06 -0600 (CST)
Received: by madman.celabo.org (Postfix, from userid 1001)
	id 2C0266D45F; Tue,  6 Jan 2004 14:31:06 -0600 (CST)
Date: Tue, 6 Jan 2004 14:31:06 -0600
From: "Jacques A. Vidrine" <nectar@FreeBSD.org>
To: Stefan Farfeleder <stefan@fafoe.narf.at>
Message-ID: <20040106203106.GC46611@madman.celabo.org>
References: <200401061843.i06IhV2L068324@repoman.freebsd.org>
	<20040106201801.GA1348@wombat.fafoe.narf.at>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040106201801.GA1348@wombat.fafoe.narf.at>
X-Url: http://www.celabo.org/
User-Agent: Mutt/1.5.4i-ja.1
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/posix1e acl_delete_entry.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jan 2004 20:31:08 -0000

On Tue, Jan 06, 2004 at 09:18:04PM +0100, Stefan Farfeleder wrote:
> @@ -61,9 +61,9 @@ acl_delete_entry(acl_t acl, acl_entry_t 
>  		if ((acl->ats_acl.acl_entry[i].ae_tag == entry_d->ae_tag) &&
>  		    (acl->ats_acl.acl_entry[i].ae_id == entry_d->ae_id)) {
>  			/* ...shift the remaining entries... */
> -			while (i < acl->ats_acl.acl_cnt - 1)
> +			for (; i < acl->ats_acl.acl_cnt - 1; ++i)
>  				acl->ats_acl.acl_entry[i] =
> -				    acl->ats_acl.acl_entry[++i];
> +				    acl->ats_acl.acl_entry[i];
> 
> I think that last assignment should read:
> 
> acl->ats_acl.acl_entry[i] = acl->ats_acl.acl_entry[i + 1];

*blush*  Um, thanks!!!
-- 
Jacques Vidrine   NTT/Verio SME      FreeBSD UNIX       Heimdal
nectar@celabo.org jvidrine@verio.net nectar@freebsd.org nectar@kth.se