From owner-freebsd-current Tue May 23 23:47:13 2000 Delivered-To: freebsd-current@freebsd.org Received: from overcee.netplex.com.au (peter1.yahoo.com [208.48.107.4]) by hub.freebsd.org (Postfix) with ESMTP id B5F3E37B9D5; Tue, 23 May 2000 23:46:57 -0700 (PDT) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 9760B1CE3; Tue, 23 May 2000 23:46:56 -0700 (PDT) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.1.1 10/15/1999 To: "Andrey A. Chernov" Cc: Bruce Evans , current@FreeBSD.ORG, jdp@FreeBSD.ORG Subject: Re: cvs commit: src/contrib/ncurses/include curses.h.in src/contrib/ncurses/ncurses/trace lib_trace.c In-Reply-To: Message from "Andrey A. Chernov" of "Tue, 23 May 2000 22:44:26 PDT." <20000523224425.B26457@freebsd.org> Date: Tue, 23 May 2000 23:46:56 -0700 From: Peter Wemm Message-Id: <20000524064656.9760B1CE3@overcee.netplex.com.au> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG "Andrey A. Chernov" wrote: > On Wed, May 24, 2000 at 02:09:24PM +1000, Bruce Evans wrote: > > > Previously it breaks system's /bin/sh so sh's trace() was wrongly renamed to > > > sh_trace() instead of fixing ncurses. > > > > FYI, it may also break ftp, but the problem is only visible when ftp is lin ked > > static, due to the problem with dynamic linkage in ld: > > > > /usr/src/usr.bin/ftp/cmds.c:906: warning: initialization makes integer from pointer without a cast > > /usr/libexec/elf/ld: Warning: size of symbol `trace' changed from 4 to 5 in lib_trace.o > > /usr/libexec/elf/ld: Warning: type of symbol `trace' changed from 1 to > 2 in lib_trace.o > > Yes, this bug is very dangerous and many places are affected so I fix > it immediately. > > The fact our ld can't detect multiply definitions when linking shared is > another issue - I recently send this to -current, but still got no reaction. This is by design. The symbol search order for dynamic linking is very clearly defined, and you *can* have lots of duplicate symbols. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message