From owner-svn-src-all@freebsd.org  Sat Jun 10 18:14:36 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 608E5BF3615
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Sat, 10 Jun 2017 18:14:36 +0000 (UTC)
 (envelope-from grehan@freebsd.org)
Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12])
 by mx1.freebsd.org (Postfix) with ESMTP id 1F33C822BF
 for <svn-src-all@freebsd.org>; Sat, 10 Jun 2017 18:14:35 +0000 (UTC)
 (envelope-from grehan@freebsd.org)
Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au
 [203.13.68.150])
 by alto.onthenet.com.au (Postfix) with ESMTPS id DE5ED20ADBF6
 for <svn-src-all@freebsd.org>; Sun, 11 Jun 2017 04:14:27 +1000 (AEST)
Received: from localhost (iredmail.onthenet.com.au [127.0.0.1])
 by iredmail.onthenet.com.au (Postfix) with ESMTP id CE369281DC8
 for <svn-src-all@freebsd.org>; Sun, 11 Jun 2017 04:14:27 +1000 (AEST)
X-Amavis-Modified: Mail body modified (using disclaimer) -
 iredmail.onthenet.com.au
Received: from iredmail.onthenet.com.au ([127.0.0.1])
 by localhost (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id T42AKIhScAhL for <svn-src-all@freebsd.org>;
 Sun, 11 Jun 2017 04:14:27 +1000 (AEST)
Received: from Peters-MacBook-Pro-2.local (unknown [67.133.97.100])
 by iredmail.onthenet.com.au (Postfix) with ESMTPSA id 5C7FB280503;
 Sun, 11 Jun 2017 04:14:24 +1000 (AEST)
Subject: Re: svn commit: r319487 - head/usr.sbin/bhyve
To: cem@freebsd.org, Marcelo Araujo <araujo@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201706020235.v522ZGeC076100@repo.freebsd.org>
 <CAG6CVpUrhJZbLftosxp1CH8p6WtLWkSWoown0BjgV7fMB5+4qg@mail.gmail.com>
From: Peter Grehan <grehan@freebsd.org>
Message-ID: <c57edc3c-f0bf-236b-43e5-6432f18b0bd1@freebsd.org>
Date: Sat, 10 Jun 2017 14:14:22 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:52.0)
 Gecko/20100101 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <CAG6CVpUrhJZbLftosxp1CH8p6WtLWkSWoown0BjgV7fMB5+4qg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.2 cv=XKlAcUpE c=1 sm=1 tr=0
 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=TZciygU8X6Kl154L5pxHDA==:17
 a=IkcTkHD0fZMA:10 a=LWSFodeU3zMA:10 a=BjELSlJ15GZdusFpcD4A:9
 a=AlDQbloNyKnxWHg6:21 a=oqx7VTMaSsGxKFIM:21 a=QEXdDO2ut3YA:10 wl=host:3
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Jun 2017 18:14:36 -0000

Hi Conrad,

> Here, keystr is not zero initialized....
> Note that strncpy below does not fill the remainder of the buffer with
> nuls if rc->password is shorter than 7 characters.
> 
>> +                * The client then sends the resulting 16-bytes response.
>> +                */
>> +#ifndef NO_OPENSSL
>> +               strncpy(keystr, rc->password, PASSWD_LENGTH);

  strncpy() is specified to zero-fill if the source is shorter than the 
length. Are we missing something ?

  The other issues you brought up look valid.

later,

Peter.