From owner-svn-ports-all@freebsd.org Sat Nov 18 10:10:45 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61A31DF3D0B; Sat, 18 Nov 2017 10:10:45 +0000 (UTC) (envelope-from gerald@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2C5CF6A973; Sat, 18 Nov 2017 10:10:45 +0000 (UTC) (envelope-from gerald@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id vAIAAiDZ049586; Sat, 18 Nov 2017 10:10:44 GMT (envelope-from gerald@FreeBSD.org) Received: (from gerald@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id vAIAAijn049585; Sat, 18 Nov 2017 10:10:44 GMT (envelope-from gerald@FreeBSD.org) Message-Id: <201711181010.vAIAAijn049585@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: gerald set sender to gerald@FreeBSD.org using -f From: Gerald Pfeifer Date: Sat, 18 Nov 2017 10:10:44 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r454422 - head/lang/gcc6 X-SVN-Group: ports-head X-SVN-Commit-Author: gerald X-SVN-Commit-Paths: head/lang/gcc6 X-SVN-Commit-Revision: 454422 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Nov 2017 10:10:45 -0000 Author: gerald Date: Sat Nov 18 10:10:43 2017 New Revision: 454422 URL: https://svnweb.freebsd.org/changeset/ports/454422 Log: Backport revision 454177 from lang/gcc7 now also to lang/gcc6, the current default GCC port: Make sure what we install is stripped (i.e., debug info is removed). The straightforward way is setting INSTALL_TARGET to install-strip, which is supported by the upstream GCC build machinery. Unfortunately this fails when running as regular user (non-root) since strip requires write permission to the files in question, and we install binaries as r-xr-xr-x by default. To work around that we need to set BINMODE to allow for write access by the user, something that's common on GNU/Linux (which is why this probably has not been noticed there). This is not necessary when running as root. (A different approach suggested was to set STRIP=true, alas that leads to many files actually not being stripped. This is due to GCC using its own script install-sh that in turn uses cp, chmod, strip,... instead of our own install-* tools in many cases.) According to tests by sobomax@ and me installs of lang/gcc6 went down by about a fourth. Do not bump PORTREVISION since this only changes builds by non-root users, is not a functional change, and the previous state of using a bit more storage had been there "forever". Reported by: Ports QA Framework, miwi, sobomax Discussed with: tijl, miwi Tested by: sobomax Differential Revision: https://reviews.freebsd.org/D10357 Modified: head/lang/gcc6/Makefile Modified: head/lang/gcc6/Makefile ============================================================================== --- head/lang/gcc6/Makefile Sat Nov 18 09:42:10 2017 (r454421) +++ head/lang/gcc6/Makefile Sat Nov 18 10:10:43 2017 (r454422) @@ -94,6 +94,10 @@ CONFIGURE_ARGS+=--disable-bootstrap CONFIGURE_ARGS+=--with-build-config=bootstrap-debug ALL_TARGET= bootstrap-lean .endif +INSTALL_TARGET= install-strip +.if ${UID} != 0 +BINMODE= 755 +.endif CONFIGURE_ARGS+=--disable-nls \ --enable-gnu-indirect-function \ --libdir=${TARGLIB} \