From owner-freebsd-ipfw@FreeBSD.ORG Sat Jun 6 05:59:05 2015 Return-Path: Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9F13BD09; Sat, 6 Jun 2015 05:59:05 +0000 (UTC) (envelope-from smithi@nimnet.asn.au) Received: from sola.nimnet.asn.au (paqi.nimnet.asn.au [115.70.110.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A736D1A1A; Sat, 6 Jun 2015 05:59:03 +0000 (UTC) (envelope-from smithi@nimnet.asn.au) Received: from localhost (localhost [127.0.0.1]) by sola.nimnet.asn.au (8.14.2/8.14.2) with ESMTP id t565wobJ087601; Sat, 6 Jun 2015 15:58:51 +1000 (EST) (envelope-from smithi@nimnet.asn.au) Date: Sat, 6 Jun 2015 15:58:50 +1000 (EST) From: Ian Smith To: Lev Serebryakov cc: freebsd-ipfw@freebsd.org Subject: Re: Please, review my change to ipfw, I want to commit it :) In-Reply-To: <20150602214303.V91076@sola.nimnet.asn.au> Message-ID: <20150606154353.M91076@sola.nimnet.asn.au> References: <556C6CBB.5010803@FreeBSD.org> <20150602214303.V91076@sola.nimnet.asn.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jun 2015 05:59:05 -0000 Lev, a further thought. I've seen melifaro's new comments, but can't comment on those except that we are agreed on really needing some usage examples. On Tue, 2 Jun 2015 22:39:40 +1000, Ian Smith wrote: > It would be nice if skip-immediate-action could be shortened, especially > where printed by ip_fw2.c .. skip-action may be enough? defer-action? This use of 'skip' bugs me in another way; it could easily be confused by some with skipto, just by use of the word. Various example rulesets actually use $skip as shorthand for 'skipto $somerule', for example. I think that 'defer' - put off to a later time, postpone - or perhaps less favourably but similar enough, 'delay', would provide clearer meaning here, especially if the deferred action is itself a 'skipto'. cheers, Ian