From owner-svn-src-head@FreeBSD.ORG Sun Dec 29 20:51:41 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 22EC4E57 for ; Sun, 29 Dec 2013 20:51:41 +0000 (UTC) Received: from nm20.bullet.mail.bf1.yahoo.com (nm20.bullet.mail.bf1.yahoo.com [98.139.212.179]) by mx1.freebsd.org (Postfix) with SMTP id B4711175C for ; Sun, 29 Dec 2013 20:51:40 +0000 (UTC) Received: from [98.139.215.140] by nm20.bullet.mail.bf1.yahoo.com with NNFMP; 29 Dec 2013 20:51:33 -0000 Received: from [98.139.211.199] by tm11.bullet.mail.bf1.yahoo.com with NNFMP; 29 Dec 2013 20:51:33 -0000 Received: from [127.0.0.1] by smtp208.mail.bf1.yahoo.com with NNFMP; 29 Dec 2013 20:51:33 -0000 X-Yahoo-Newman-Id: 819451.83151.bm@smtp208.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: XY9J7r0VM1miGbQWyKRGKEzhVdGk63.9oMBdnkF9SSK5lY4 U7bzLJzLcx3lem8VMMihySLNyfN3w5NEewhTyfRqwm0C4OBokKrT4dDtZ5E2 zAvFjgR29Pm1FooPOHF6VVxgprcoyp2RaOFSuTYl3DRUXcWiZ5aPNY5hyMro ujHJNdOaM_hoTYPndn0LlV8b3aS_X9j8_KlJItxYYFGN4VVr7zrTxzaop6aY zAKZgMtzZe7UH1avK63_xgYzwuwh_5Yllccv7y0a.zaUzEr.qLdS2.eXs.G6 PEr3DpOcpiPgCakLYi.xzLrpz_RIr8MZnQKItCo2pMit0kReZDV0Ij7NgLz7 Q2VD_NsNrSJ0ZMSIWXXuA0XNQ0Ji3NS.DpZcq1PBzTEXdrYZaQwEIlRn1GjQ 0I0bekE5Wlv0IZLpKInIiUypDR2YuY.HuG4_LQZnU5l4zXmDKHSxevp.h9qk qprvxQMp15lNPuoTZPhEfbkvBrSGfZJEBWvqZFHClZDEolLC.Z5LAL3jyKpw Pto0pO1btbNFJv5LHLgiyXB3rA9fPuaZPcuS.ICZVnr4m2WkMtZAhClg- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf X-Rocket-Received: from [192.168.0.102] (pfg@190.157.126.109 with plain [98.138.105.21]) by smtp208.mail.bf1.yahoo.com with SMTP; 29 Dec 2013 12:51:33 -0800 PST Message-ID: <52C08B47.70106@FreeBSD.org> Date: Sun, 29 Dec 2013 15:51:19 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Dimitry Andric , Adrian Chadd Subject: Re: svn commit: r259896 - head/sys/dev/cxgb/common References: <201312252245.rBPMjX5J046556@svn.freebsd.org> <76C5CECF-1A27-4245-B5D1-335C46B253E7@FreeBSD.org> In-Reply-To: <76C5CECF-1A27-4245-B5D1-335C46B253E7@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2013 20:51:41 -0000 On 26.12.2013 06:13, Dimitry Andric wrote: > On 26 Dec 2013, at 02:51, Adrian Chadd wrote: >> I'd prefer you didn't remove unused code in drivers like this. If you >> must, #if 0 them out. > I don't mind either way, but some other people are very much opposed to > littering code with #if 0'd sections. So, how do to determine what is > right in each situation? :-) > FWIW, I am also in favor of removing instead of #if 0. If we really need the code back, we have subversion for that. I guess an exception would be on contributed code, where one still wants to keep things similar. Just my 0.02$, no strong feelings about either way. Pedro.