From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Apr 22 19:40:06 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4C5E0106564A for ; Sun, 22 Apr 2012 19:40:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2528F8FC14 for ; Sun, 22 Apr 2012 19:40:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3MJe5Ok041855 for ; Sun, 22 Apr 2012 19:40:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3MJe5Jx041854; Sun, 22 Apr 2012 19:40:05 GMT (envelope-from gnats) Resent-Date: Sun, 22 Apr 2012 19:40:05 GMT Resent-Message-Id: <201204221940.q3MJe5Jx041854@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kevin Zheng Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3BB11065674 for ; Sun, 22 Apr 2012 19:37:24 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 85C4A8FC17 for ; Sun, 22 Apr 2012 19:37:24 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q3MJbO27005813 for ; Sun, 22 Apr 2012 19:37:24 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q3MJbOc8005812; Sun, 22 Apr 2012 19:37:24 GMT (envelope-from nobody) Message-Id: <201204221937.q3MJbOc8005812@red.freebsd.org> Date: Sun, 22 Apr 2012 19:37:24 GMT From: Kevin Zheng To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/167212: [maintainer-update] Patch to add desktop icon for games/crossfire-client X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2012 19:40:06 -0000 >Number: 167212 >Category: ports >Synopsis: [maintainer-update] Patch to add desktop icon for games/crossfire-client >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Sun Apr 22 19:40:05 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Kevin Zheng >Release: FreeBSD 9.0-RELEASE >Organization: >Environment: FreeBSD omega.local 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:15:25 UTC 2012 root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: Most users like having a desktop icon created in the Applications menu after a graphical program (especially a game) is installed. This patch allows games/crossfire-client to install (and uninstall) a desktop icon in the applications folder. A small change to whitespace was made, and pkg-plist now tries to remove share/applications and share/pixmap if empty. The committer of this port should decide whether a bump to PORTREVISION is necessary. This patch only adds a desktop icon and doesn't otherwise change the functionality of the port. >How-To-Repeat: Simply install crossfire-client from ports and you'll quickly realize that there is no desktop icon. >Fix: Apply the attached patch. Patch attached with submission follows: diff -ruN /usr/ports/games/crossfire-client/Makefile crossfire-client/Makefile --- /usr/ports/games/crossfire-client/Makefile 2012-04-15 10:43:10.000000000 -0500 +++ crossfire-client/Makefile 2012-04-22 14:32:28.000000000 -0500 @@ -1,6 +1,6 @@ # New ports collection makefile for: crossfire-client -# Date created: 1996-10-27 -# Whom: Andreas Klemm +# Date created: 1996-10-27 +# Whom: Andreas Klemm # # $FreeBSD: ports/games/crossfire-client/Makefile,v 1.77 2012/04/15 15:43:10 pawel Exp $ # @@ -28,4 +28,11 @@ ${REINPLACE_CMD} -e "/mandir='${datarootdir}\/man'/d" \ ${WRKSRC}/configure +post-install: + ${CP} ${WRKSRC}/pixmaps/48x48.png ${WRKSRC}/pixmaps/crossfire-client.png + ${INSTALL_DATA} ${WRKSRC}/gtk-v2/crossfire-client.desktop \ + ${LOCALBASE}/share/applications + ${INSTALL_DATA} ${WRKSRC}/pixmaps/crossfire-client.png \ + ${LOCALBASE}/share/pixmaps + .include diff -ruN /usr/ports/games/crossfire-client/pkg-plist crossfire-client/pkg-plist --- /usr/ports/games/crossfire-client/pkg-plist 2012-04-15 10:43:10.000000000 -0500 +++ crossfire-client/pkg-plist 2012-04-22 14:13:18.000000000 -0500 @@ -1,5 +1,7 @@ bin/cfsndserv bin/crossfire-client-gtk2 +share/applications/crossfire-client.desktop +share/pixmaps/crossfire-client.png %%DATADIR%%/glade-gtk2/caelestis.glade %%DATADIR%%/glade-gtk2/chthonic.glade %%DATADIR%%/glade-gtk2/dialogs.glade @@ -17,3 +19,5 @@ @dirrm %%DATADIR%%/glade-gtk2 @dirrm %%DATADIR%%/themes @dirrm %%DATADIR%% +@dirrmtry share/applications +@dirrmtry share/pixmaps >Release-Note: >Audit-Trail: >Unformatted: