From owner-freebsd-current Mon Nov 30 23:13:52 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA23741 for freebsd-current-outgoing; Mon, 30 Nov 1998 23:13:52 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from root.com (root.com [198.145.90.17]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA23734 for ; Mon, 30 Nov 1998 23:13:50 -0800 (PST) (envelope-from root@root.com) Received: from root.com (localhost [127.0.0.1]) by root.com (8.8.8/8.8.5) with ESMTP id XAA26714; Mon, 30 Nov 1998 23:14:06 -0800 (PST) Message-Id: <199812010714.XAA26714@root.com> To: Matthew Dillon cc: freebsd-current@FreeBSD.ORG Subject: Re: D.O.S. attack protection enhancements commit (ICMP_BANDLIM) In-reply-to: Your message of "Mon, 30 Nov 1998 22:07:47 PST." <199812010607.WAA03051@apollo.backplane.com> From: David Greenman Reply-To: dg@root.com Date: Mon, 30 Nov 1998 23:14:06 -0800 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > I would like to make a commit to -current similar to the following > (the one below is actually relative to -stable, but we are in final > testing of the same patch to our -current tree). > > The commit I want to commit is just the ICMP_BANDLIM section. I am The only comment I have at the moment is that the patches need a little KNF work. The mixing of indentation amounts within a function is particularly annoying and makes the code difficult to read. Indents should be tabs, with half tabs (4 spaces) used on continued lines (such as if () conditionals). The patches have other KNF problems as well...see 'man 9 style'. In principle, I'm not against these sorts of changes, but I tend to think that a more general scheme implemented perhaps inside the ipfw framework would be more appropriate. I also generally like to avoid compile time options for things like this, but I"m sympathetic for performance reducing enhancements. -DG David Greenman Co-founder/Principal Architect, The FreeBSD Project To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message